[Libreoffice-commits] online.git: loleaflet/src

[Tor Lillqvist (via logerrit)]

 loleaflet/src/control/Control.ContextMenu.js |   25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

New commits:
commit 89268f5bf3b7caa48bb96882ad5df420878a9541
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Tue Mar 17 11:50:50 2020 +0200
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Tue Mar 17 12:24:59 2020 +0100

    Non-semantic change for clarity, and related comments
    
    Let's keep the mobileBlackList elements in the same order as they
    appear in the whitelist arrays above.
    
    Change-Id: I4abb64b14be212985e45e0c0845b0c7a3ac16ced
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90608
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tor Lillqvist <tml at collabora.com>

diff --git a/loleaflet/src/control/Control.ContextMenu.js b/loleaflet/src/control/Control.ContextMenu.js
index c606ef5a1..352978e52 100644
--- a/loleaflet/src/control/Control.ContextMenu.js
+++ b/loleaflet/src/control/Control.ContextMenu.js
@@ -1,4 +1,4 @@
-/* -*- js-indent-level: 8 -*- */
+/* -*- js-indent-level: 8; fill-column: 100 -*- */
 /*
 * Control.ContextMenu
 */
@@ -58,12 +58,23 @@ L.Control.ContextMenu = L.Control.extend({
 		},
 		// UNOCOMMANDS_EXTRACT_END <- don't remove this line, it's used by unocommands.py
 
-		// This black list contains those menu items which should be disabled on mobile even if they
-		// are allowed in general. We need to have only those items here which are also part
-		// of the whitelist, otherwise the menu items are not visible anyway.
-		mobileBlackList: ['SpellingAndGrammarDialog', 'FontDialog', 'FontDialogForParagraph',
-				  'TransformDialog', 'FormatLine', 'FormatArea',
-				  'FormatCellDialog', 'ShowNote', 'DeleteNote' ]
+		// This blacklist contains those menu items which should be disabled on mobile
+		// phones even if they are allowed in general. We need to have only those items here
+		// which are also part of the whitelist, otherwise the menu items are not visible
+		// anyway.
+
+		// For clarity, please keep this list in sections that are sorted in the same order
+		// as the items appear in the whitelist arrays above. Also keep items on separate
+		// lines as in the arrays above.
+		mobileBlackList: [
+			// general
+			'TransformDialog', 'FormatLine', 'FormatArea',
+			// text
+			'SpellingAndGrammarDialog', 'FontDialog', 'FontDialogForParagraph',
+			// spreadsheet
+			'FormatCellDialog',
+			'ShowNote', 'DeleteNote',
+		]
 	},