[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - include/comphelper
Tor Lillqvist (via logerrit)
logerrit at kemper.freedesktop.org
Wed Mar 18 10:03:15 UTC 2020
include/comphelper/lok.hxx | 5 +++++
1 file changed, 5 insertions(+)
New commits:
commit 191d2349eeb2033ecd08e2aa293bb6413538e6c0
Author: Tor Lillqvist <tml at collabora.com>
AuthorDate: Wed Mar 18 10:58:52 2020 +0200
Commit: Tor Lillqvist <tml at collabora.com>
CommitDate: Wed Mar 18 11:02:52 2020 +0100
Clarify the WIP-ness of setMobilePhone() and setTablet() a bit
Change-Id: Iee8b773e23ebd3fbc1ba5bf2c56d644d0844cb2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90682
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Tor Lillqvist <tml at collabora.com>
diff --git a/include/comphelper/lok.hxx b/include/comphelper/lok.hxx
index d88ddfd1dfa5..43191db90ec0 100644
--- a/include/comphelper/lok.hxx
+++ b/include/comphelper/lok.hxx
@@ -29,6 +29,11 @@ namespace LibreOfficeKit
COMPHELPER_DLLPUBLIC void setActive(bool bActive = true);
+// Note that currently it is undefined behaviour to call both setMobilePhone() and setTablet(). This
+// will be remedied in the future. For now, just make sure you call just either for a view, and just
+// once, with the bool parameter as true. In the future, this will probably be changed into using an
+// enum for the kind of the view, that can be DESKTOP, MOBILEPHONE, or TABLET.
+
// Tell that LOK view is on a mobile phone (regardless what its pixel resolution is, whether its form factor is "phablet" or not)
COMPHELPER_DLLPUBLIC void setMobilePhone(int nViewId, bool bIsMobilePhone);
More information about the Libreoffice-commits
mailing list