[Libreoffice-commits] online.git: loleaflet/src

Tamás Zolnai (via logerrit) logerrit at kemper.freedesktop.org
Thu Mar 19 11:01:02 UTC 2020


 loleaflet/src/layer/vector/Path.Drag.js |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b33e97e623c41e3de0f58017249d7be476fd305d
Author:     Tamás Zolnai <tamas.zolnai at collabora.com>
AuthorDate: Thu Mar 19 02:05:18 2020 +0100
Commit:     Tamás Zolnai <tamas.zolnai at collabora.com>
CommitDate: Thu Mar 19 12:00:42 2020 +0100

    mobile: fix type error hit by cypress test.
    
    The issue comes up when we get a drag-end event
    without a drag-start event.
    Not sure wether this error can happen in real life
    or it's just the cypress test framework mobile emulation
    which can lead to this issue, but an additional check
    won't hurt.
    
    Change-Id: I352a5b523e8400ffc5e77ebefd91166e40517019
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90724
    Tested-by: Tamás Zolnai <tamas.zolnai at collabora.com>
    Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>

diff --git a/loleaflet/src/layer/vector/Path.Drag.js b/loleaflet/src/layer/vector/Path.Drag.js
index 47fd8e0e2..c85a9ac32 100644
--- a/loleaflet/src/layer/vector/Path.Drag.js
+++ b/loleaflet/src/layer/vector/Path.Drag.js
@@ -269,7 +269,7 @@ L.Handler.PathDrag = L.Handler.extend(/** @lends  L.Path.Drag.prototype */ {
 			this._path._map.dragging.enable();
 		}
 
-		if (!this._path.options.manualDrag && !moved) {
+		if (!this._path.options.manualDrag && !moved && this._mouseDown) {
 			this._path._map._handleDOMEvent(this._mouseDown);
 			this._path._map._handleDOMEvent(evt);
 		}


More information about the Libreoffice-commits mailing list