[Libreoffice-commits] core.git: toolkit/qa

[Stephan Bergmann (via logerrit)]

 toolkit/qa/cppunit/Dialog.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 1be7a056ff843e8e9cb80890ecf7d3aa852557e9
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Mar 20 13:19:57 2020 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Mar 20 17:18:43 2020 +0100

    Dispose dialog created during test
    
    I experienced crashes during shutdown of CppunitTest_toolkit at least with
    --enable-lto,
    
    [...]
    > OK (2)
    > warn:vcl:109889:109889:vcl/source/app/svmain.cxx:460: DeInitVCL: some top Windows are still alive
    > text = "" type = "N7toolkit16ScrollableDialogE", ptr = 0x216b740
    >
    > warn:fwk.desktop:109889:109889:framework/source/services/desktop.cxx:1065: Desktop disposed before terminating it
    > warn:fwk.desktop:109889:109889:framework/source/services/desktop.cxx:179: Desktop not terminated before being destructed
    > warn:unotools.config:109889:109889:unotools/source/config/configmgr.cxx:140: ConfigManager not empty
    > cppunittester: /home/sbergman/lo2/core/include/vcl/vclptr.hxx:106: VclPtr<reference_type>::~VclPtr() [with reference_type = vcl::Window]: Assertion `m_rInnerRef.get() == nullptr || vclmain::isAlive()' failed.
    
    Change-Id: I419b7ef8e23c94a906e3de6b3a55b63e13650abe
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90790
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/toolkit/qa/cppunit/Dialog.cxx b/toolkit/qa/cppunit/Dialog.cxx
index c58b9b4768ca..5f02c58bee61 100644
--- a/toolkit/qa/cppunit/Dialog.cxx
+++ b/toolkit/qa/cppunit/Dialog.cxx
@@ -65,6 +65,7 @@ CPPUNIT_TEST_FIXTURE(DialogTest, testDialogSizeable)
     CPPUNIT_ASSERT(pWindow->GetStyle() & WB_SIZEABLE);
 
     xDialog->endExecute();
+    css::uno::Reference<css::lang::XComponent>(xDialog, css::uno::UNO_QUERY_THROW)->dispose();
 }
 }