[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sw/qa

[Jan Holesovsky (via logerrit)]

 sw/qa/extras/inc/swmodeltestbase.hxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 0d1e49036820e7b9c0d063305e0773ea3e42ea80
Author:     Jan Holesovsky <kendy at collabora.com>
AuthorDate: Fri Mar 13 12:21:40 2020 +0100
Commit:     Jan Holesovsky <kendy at collabora.com>
CommitDate: Thu Mar 26 12:45:40 2020 +0100

    sw unit testing: Don't force EnableKillingFile() in save().
    
    This is an unexpected sideeffect, it should be up to the caller to
    decide whether to enable or disable removal of the tempfile; otherwise
    a debugging code like:
    
        utl::TempFile aTempFile;
        aTempFile.EnableKillingFile(false);
        SAL_DEBUG("tempfile: " << aTempFile.GetURL());
        save("writer8", aTempFile);
    
    does not preserve the temp file.
    
    Change-Id: If57cc9cee683c8373cf3faba4a6f23ce78121012
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90461
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Jan Holesovsky <kendy at collabora.com>

diff --git a/sw/qa/extras/inc/swmodeltestbase.hxx b/sw/qa/extras/inc/swmodeltestbase.hxx
index d3d64c8ea434..57da6dc60c83 100644
--- a/sw/qa/extras/inc/swmodeltestbase.hxx
+++ b/sw/qa/extras/inc/swmodeltestbase.hxx
@@ -861,7 +861,6 @@ protected:
     /// Save the loaded document to a tempfile. Can be used to check the resulting docx/odt directly as a ZIP file.
     void save(const OUString& aFilterName, utl::TempFile& rTempFile)
     {
-        rTempFile.EnableKillingFile();
         uno::Reference<frame::XStorable> xStorable(mxComponent, uno::UNO_QUERY);
         utl::MediaDescriptor aMediaDescriptor;
         aMediaDescriptor["FilterName"] <<= aFilterName;