[Libreoffice-commits] core.git: sw/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Mar 27 10:00:38 UTC 2020


 sw/source/uibase/utlui/glbltree.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a5d8e924531ee6938df92fa9d1508ee2a3118554
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Mar 27 09:13:23 2020 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Mar 27 10:59:58 2020 +0100

    cid#1460973 Explicit null dereferenced
    
    Change-Id: Ibdeae2e76cda7cf13cb5f3db998462c1ada7bb96
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91192
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sw/source/uibase/utlui/glbltree.cxx b/sw/source/uibase/utlui/glbltree.cxx
index 77ca2543ccb5..3261050f3a6c 100644
--- a/sw/source/uibase/utlui/glbltree.cxx
+++ b/sw/source/uibase/utlui/glbltree.cxx
@@ -950,7 +950,7 @@ void SwGlobalTree::OpenDoc(const SwGlblDocContent* pCont)
 IMPL_LINK_NOARG( SwGlobalTree, DoubleClickHdl, weld::TreeView&, bool)
 {
     int nEntry = m_xTreeView->get_cursor_index();
-    SwGlblDocContent* pCont = nEntry != -1 ? reinterpret_cast<SwGlblDocContent*>(m_xTreeView->get_id(nEntry).toInt64()) : nullptr;
+    SwGlblDocContent* pCont = reinterpret_cast<SwGlblDocContent*>(m_xTreeView->get_id(nEntry).toInt64());
     if (pCont->GetType() == GLBLDOC_SECTION)
         OpenDoc(pCont);
     else


More information about the Libreoffice-commits mailing list