[Libreoffice-commits] core.git: cui/source

[Julien Nabet (via logerrit)]

 cui/source/tabpages/tpline.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit e0550b3c0969a8ff70028d2c02b56ced058b0d9a
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Sun Mar 29 15:23:50 2020 +0200
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Sun Mar 29 16:11:57 2020 +0200

    Related tdf#131333: Cannot change data point icons in Calc's XY chart
    
    Don't know if it's related but thought this log should be taken into account:
    warn:legacy.osl:68288:68288:svx/source/svdraw/svdpage.cxx:770: OSL_ASSERT: nNum<maList.size()
    
    At least, since we can know the number of objects, just use it to limit the loop
    
    Change-Id: I79ca467b6da8e22e3e7cd9fb5dc2451e2514316f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91327
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx
index 98ce79ad80f1..881d5108a1c1 100644
--- a/cui/source/tabpages/tpline.cxx
+++ b/cui/source/tabpages/tpline.cxx
@@ -1457,11 +1457,10 @@ IMPL_LINK_NOARG(SvxLineTabPage, MenuCreateHdl_Impl, weld::ToggleButton&, void)
             pInvisibleSquare->SetMergedItem(XFillTransparenceItem(100));
             pInvisibleSquare->SetMergedItem(XLineTransparenceItem(100));
 
-            for(size_t i=0;; ++i)
+            for(size_t i=0; i < m_pSymbolList->GetObjCount(); ++i)
             {
                 SdrObject *pObj=m_pSymbolList->GetObj(i);
-                if(pObj==nullptr)
-                    break;
+                assert(pObj);
 
                 // directly clone to target SdrModel
                 pObj = pObj->CloneSdrObject(*pModel);