[Libreoffice-commits] online.git: loleaflet/src

Tor Lillqvist (via logerrit) logerrit at kemper.freedesktop.org
Mon Mar 30 10:12:59 UTC 2020


 loleaflet/src/control/Control.Toolbar.js |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 799fee972b61ecaf10fb70a5dc999dfa293838c5
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Mon Mar 30 12:42:54 2020 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Mon Mar 30 12:12:41 2020 +0200

    Clarify meaning of the mobile and tablet properties in the toolItems elements
    
    In particular, also here "mobile" actually means "mobile phone" and
    not a mobile devie in general.
    
    Change-Id: If3bdf0ae9fa2da43364413ab08387053d67121b2
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91351
    Tested-by: Tor Lillqvist <tml at collabora.com>
    Reviewed-by: Tor Lillqvist <tml at collabora.com>

diff --git a/loleaflet/src/control/Control.Toolbar.js b/loleaflet/src/control/Control.Toolbar.js
index c09f4a427..059dc28e5 100644
--- a/loleaflet/src/control/Control.Toolbar.js
+++ b/loleaflet/src/control/Control.Toolbar.js
@@ -812,9 +812,6 @@ function hideTooltip(toolbar, id) {
 var stylesSelectValue;
 var fontsSelectValue;
 
-// mobile:false means hide it both for normal Online used from a mobile browser, and in a mobile app
-// mobilebrowser:false means hide it for normal Online used from a mobile browser, but don't hide it in a mobile app
-
 function createToolbar() {
 
 	if (window.mode.isMobile()) {
@@ -826,6 +823,11 @@ function createToolbar() {
 	}
 }
 
+// mobile:false means hide it both for normal Online used from a mobile phone browser, and in a mobile app on a mobile phone
+// mobilebrowser:false means hide it for normal Online used from a mobile browser, but don't hide it in a mobile app
+// tablet:true means show it in normal Online from a tablet browser, and in a mobile app on a tablet
+// tablet:false means hide it in normal Online used from a tablet browser, and in a mobile app on a tablet
+
 function initNormalToolbar() {
 	var toolItems = [
 		{type: 'button',  id: 'closemobile',  img: 'closemobile', desktop: false, mobile: false, tablet: true, hidden: true},


More information about the Libreoffice-commits mailing list