[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/data/xlsx/tdf66668.xlsx    |binary
 sc/qa/unit/subsequent_export-test.cxx |   14 ++++++++++++++
 2 files changed, 14 insertions(+)

New commits:
commit 3ea44e0072c97611de0285d9080f11fcfdac1028
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Fri May 1 00:42:52 2020 +0200
Commit:     Xisco Faulí <xiscofauli at libreoffice.org>
CommitDate: Fri May 1 12:03:49 2020 +0200

    tdf#66668: sc: Add unittest
    
    Change-Id: Iccc60a5847987f3dc0b4a47e55d0886ada63e4d9
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93236
    Tested-by: Jenkins
    Reviewed-by: Xisco Faulí <xiscofauli at libreoffice.org>

diff --git a/sc/qa/unit/data/xlsx/tdf66668.xlsx b/sc/qa/unit/data/xlsx/tdf66668.xlsx
new file mode 100644
index 000000000000..1143ad8ea7cc
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf66668.xlsx differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx b/sc/qa/unit/subsequent_export-test.cxx
index 9493ede62556..de4344afbb2f 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -194,6 +194,7 @@ public:
     void testPreserveTextWhitespaceXLSX();
     void testPreserveTextWhitespace2XLSX();
     void testTextDirectionXLSX();
+    void testTdf66668();
     void testTdf55417();
     void testTdf129985();
     void testTdf73063();
@@ -336,6 +337,7 @@ public:
     CPPUNIT_TEST(testMoveCellAnchoredShapesODS);
     CPPUNIT_TEST(testMatrixMultiplicationXLSX);
     CPPUNIT_TEST(testTextDirectionXLSX);
+    CPPUNIT_TEST(testTdf66668);
     CPPUNIT_TEST(testTdf55417);
     CPPUNIT_TEST(testTdf129985);
     CPPUNIT_TEST(testTdf73063);
@@ -4020,6 +4022,18 @@ void ScExportTest::testTextDirectionXLSX()
     xDocSh->DoClose();
 }
 
+void ScExportTest::testTdf66668()
+{
+    // Would hang on exporting without the fix in place
+    ScDocShellRef xDocSh = loadDoc("tdf66668.", FORMAT_XLSX);
+    CPPUNIT_ASSERT_MESSAGE("Failed to open doc", xDocSh.is());
+
+    xmlDocPtr pDoc = XPathHelper::parseExport2(*this, *xDocSh, m_xSFactory, "xl/styles.xml", FORMAT_XLSX);
+    CPPUNIT_ASSERT(pDoc);
+
+    xDocSh->DoClose();
+}
+
 void ScExportTest::testTdf55417()
 {
     ScDocShellRef xDocSh = loadDoc("tdf55417.", FORMAT_XLSX);