[Libreoffice-commits] core.git: writerfilter/source

Miklos Vajna (via logerrit) logerrit at kemper.freedesktop.org
Tue May 5 07:07:16 UTC 2020


 writerfilter/source/ooxml/factoryimpl_ns.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 62ba3248f654febe55fdf422163fff76552e9c32
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Mon May 4 21:11:55 2020 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Tue May 5 09:06:42 2020 +0200

    tdf#132320 writerfilter: fix typo in factoryimpl_ns.py
    
    Regression from 821ab16a1fb0353397914131ab559685d12b92b7 (writerfilter:
    convert factoryimpl_ns to Python, 2014-07-27), this was probably
    unnoticed so far, because writerfilter/qa/ooxml/watch-generated-code.sh
    says the end result is the same with or without this.
    
    Change-Id: I570c411c26a399db1df94b56eebce83fe716ae57
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93440
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/writerfilter/source/ooxml/factoryimpl_ns.py b/writerfilter/source/ooxml/factoryimpl_ns.py
index 35fdadfd3a9d..db06cf1c9218 100644
--- a/writerfilter/source/ooxml/factoryimpl_ns.py
+++ b/writerfilter/source/ooxml/factoryimpl_ns.py
@@ -399,7 +399,7 @@ def charactersActionForValues(nsNode, refNode):
     ret = []
 
     refName = refNode.getAttribute("name")
-    for defineNode in [i for i in getChildrenByName(getChildByName(nsNode, "grammar"), "define") if defineNode.getAttribute("name") == refName]:
+    for defineNode in [i for i in getChildrenByName(getChildByName(nsNode, "grammar"), "define") if i.getAttribute("name") == refName]:
         ret.append("    {")
         ret.append("    // %s" % defineNode.getAttribute("name"))
         for dataNode in getChildrenByName(defineNode, "data"):


More information about the Libreoffice-commits mailing list