[Libreoffice-commits] core.git: sd/qa

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Wed May 6 20:24:54 UTC 2020


 sd/qa/unit/import-tests.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit b71bf2bca1eb789fce672566a8098426e0d793f3
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed May 6 20:59:49 2020 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed May 6 22:24:21 2020 +0200

    loplugin:makeshared
    
    See the commit message of 78761f9b0177b0ae8ccfc5323a530fe4404b9637 "Make
    disabled PDF import tests compile again" for the conditions under which this
    code would actually be built.
    
    Change-Id: I596a7ade07d7aeb2cac0f98e7e19adad2414d26c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93587
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 158641ae4b81..e0a20087308a 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -13,7 +13,6 @@
 #include <config_poppler.h>
 #include <memory>
 #include <ostream>
-#include <utility>
 #include <sdpage.hxx>
 
 #include "sdmodeltestbase.hxx"
@@ -1366,10 +1365,10 @@ void SdImportTest::testPDFImport()
 
 void SdImportTest::testPDFImportSkipImages()
 {
-    auto pParams = std::make_unique<SfxAllItemSet>( SfxGetpApp()->GetPool() );
+    auto pParams = std::make_shared<SfxAllItemSet>( SfxGetpApp()->GetPool() );
     pParams->Put( SfxStringItem ( SID_FILE_FILTEROPTIONS, "SkipImages" ) );
 
-    sd::DrawDocShellRef xDocShRef = loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/pdf/txtpic.pdf"), PDF, std::move(pParams));
+    sd::DrawDocShellRef xDocShRef = loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/pdf/txtpic.pdf"), PDF, pParams);
     SdDrawDocument *pDoc = xDocShRef->GetDoc();
     CPPUNIT_ASSERT_MESSAGE( "no document", pDoc != nullptr );
     uno::Reference< drawing::XDrawPagesSupplier > xDoc(xDocShRef->GetDoc()->getUnoModel(), uno::UNO_QUERY_THROW );


More information about the Libreoffice-commits mailing list