[Libreoffice-commits] core.git: Changes to 'feature/calc-coordinates'
Dennis Francis (via logerrit)
logerrit at kemper.freedesktop.org
Mon May 11 11:29:52 UTC 2020
New branch 'feature/calc-coordinates' available with the following commits:
commit 146b18e04d5cfd0e5b6cda124e2407264ea08029
Author: Dennis Francis <dennis.francis at collabora.com>
Date: Fri May 8 13:27:50 2020 +0530
Unit tests for ITiledRenderable::getSheetGeometryData()
(Testing of groups/ouline case is not included)
Change-Id: Ia53e5489c376d2d86461a9fd3db4f5b7dc963b99
commit 517e7d1058c6676a2e1e35077b1b865c9c9cf7d7
Author: Dennis Francis <dennis.francis at collabora.com>
Date: Tue May 5 01:55:37 2020 +0530
Introduce ITiledRenderable::getSheetGeometryData()
ITiledRenderable::getSheetGeometryData(bool bColumns, bool bRows,
bool bSizes, bool bHidden,
bool bFiltered, bool bGroups)
and implement it for the Calc derivation (ScModelObj).
The aim is to use it actively in LOOL instead of the interface:
ITiledRenderable::getRowColumnHeaders(const tools::Rectangle& /*rRectangle*/)
This is used by the LOOL to fetch the sheet geometry data for just the
current view-area in the clients, so LOOL queries this everytime some
client's view-area changes.
Like the existing interface, the new one will provide all 'kinds' of
sheet geometry info [col/row sizes(twips), hidden/filtered and
grouping]. But the difference is, it generates data for the whole sheet
(not view-area specific). So the method need not be queried every time
the view area changes in the LOOL clients, and more importantly it
enables the clients to locate any cell at any zoom level without any
further help from the core. This means core needn't send various
client(zoom) specific positioning messages in pixel aligned twips. It
just can send all positioning messages in print twips uniformly to all
clients.
Change-Id: Ib6aee9a0c92746b1576ed244e98cb54b572778c0
improvements: squash to 9d11daebb
Change-Id: I55eafcde514573c3701756da6e7c888a2faaa6e7
More information about the Libreoffice-commits
mailing list