[Libreoffice-commits] online.git: cypress_test/integration_tests

Henry Castro (via logerrit) logerrit at kemper.freedesktop.org
Wed May 13 15:44:40 UTC 2020


 cypress_test/integration_tests/mobile/writer/shape_properties_spec.js |   15 ++--------
 1 file changed, 3 insertions(+), 12 deletions(-)

New commits:
commit 42f833675744d8ddcd9e059de78546a278f7f6a0
Author:     Henry Castro <hcastro at collabora.com>
AuthorDate: Wed May 13 09:12:32 2020 -0400
Commit:     Henry Castro <hcastro at collabora.com>
CommitDate: Wed May 13 17:44:22 2020 +0200

    cypress: enable skipped unit test for "writer/shape_properties_spec.js"
    
    Enable unit test related to Spin button controls changes
    
    Change-Id: Ib2f0098d5d0b9f8b6eae28a4cce8680c6378e623
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94124
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Henry Castro <hcastro at collabora.com>

diff --git a/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js b/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
index feb8582f3..d111f59b1 100644
--- a/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
+++ b/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
@@ -81,11 +81,7 @@ describe('Change shape properties via mobile wizard.', function() {
 			.should('have.attr', 'fill', 'rgb(114,159,207)');
 	});
 
-	// Regression here: we can't enter value directly into the spinfield
-	it.skip('Change shape width.', function() {
-		// TODO: Entering a value inside the spinbutton has no effect on the shape.
-		if (Cypress.env('LO_CORE_VERSION') === 'master')
-			return;
+	it('Change shape width.', function() {
 
 		openPosSizePanel();
 
@@ -101,11 +97,7 @@ describe('Change shape properties via mobile wizard.', function() {
 			.should('have.attr', 'd', 'M 1965,4863 L 12635,10855 1965,10855 1965,4863 1965,4863 Z');
 	});
 
-	// Regression here: we can't enter value directly into the spinfield
-	it.skip('Change shape height.', function() {
-		// TODO: Entering a value inside the spinbutton has no effect on the shape.
-		if (Cypress.env('LO_CORE_VERSION') === 'master')
-			return;
+	it('Change shape height.', function() {
 
 		openPosSizePanel();
 
@@ -267,8 +259,7 @@ describe('Change shape properties via mobile wizard.', function() {
 			.should('have.attr', 'stroke-width', '88');
 	});
 
-	// Regression here: we can't enter value directly into the spinfield
-	it.skip('Change line transparency', function() {
+	it('Change line transparency', function() {
 		// TODO: Layout of the line properties panel is completely broken.
 		if (Cypress.env('LO_CORE_VERSION') === 'master')
 			return;


More information about the Libreoffice-commits mailing list