[Libreoffice-commits] core.git: sw/qa

Miklos Vajna (via logerrit) logerrit at kemper.freedesktop.org
Mon May 25 18:58:52 UTC 2020


 sw/qa/uitest/writer_tests4/tdf113284.py |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 036728422524fea034327b204d95e29ccc18c66b
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Mon May 25 18:03:34 2020 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Mon May 25 20:58:20 2020 +0200

    UITest_writer_tests4: fix this under high load
    
    The failure I had:
    
            ======================================================================
            FAIL: test_tdf113284 (tdf113284.tdf113284)
            ----------------------------------------------------------------------
            Traceback (most recent call last):
              File "sw/qa/uitest/writer_tests4/tdf113284.py", line 34, in test_tdf113284
                self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], str(xPageCount))
            AssertionError: '1' != '91'
            - 1
            + 91
            ? +
    
    And with this in place 'make check' passes just fine. I assume the go to
    page dialog goes to the relevant page in an async way.
    
    Change-Id: Ic4b2a755c589f113af58b5fb3e43f537a52a50d9
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94803
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>
    Tested-by: Jenkins

diff --git a/sw/qa/uitest/writer_tests4/tdf113284.py b/sw/qa/uitest/writer_tests4/tdf113284.py
index 11c867ecea14..83494b2a79b1 100644
--- a/sw/qa/uitest/writer_tests4/tdf113284.py
+++ b/sw/qa/uitest/writer_tests4/tdf113284.py
@@ -30,6 +30,8 @@ class tdf113284(UITestCase):
     xPageText.executeAction("TYPE", mkPropertyValues({"TEXT":str(xPageCount)})) # goto last page
     xOkBtn = xDialog.getChild("ok")
     self.ui_test.close_dialog_through_button(xOkBtn)
+    xToolkit = self.xContext.ServiceManager.createInstance('com.sun.star.awt.Toolkit')
+    xToolkit.processEventsToIdle()
 
     self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], str(xPageCount))
     self.ui_test.execute_dialog_through_command(".uno:EditCurIndex")  #open index dialog
@@ -43,4 +45,4 @@ class tdf113284(UITestCase):
     self.assertEqual(document.CurrentController.PageCount, xPageCount)
 
     self.ui_test.close_doc()
-# vim: set shiftwidth=4 softtabstop=4 expandtab:
\ No newline at end of file
+# vim: set shiftwidth=4 softtabstop=4 expandtab:


More information about the Libreoffice-commits mailing list