[Libreoffice-commits] core.git: Changes to 'private/mmeeks/cp64merge'
Jan Holesovsky (via logerrit)
logerrit at kemper.freedesktop.org
Wed May 27 21:39:29 UTC 2020
New branch 'private/mmeeks/cp64merge' available with the following commits:
commit a30bb3a439a3d54e372ce3b8a22598e01d3a17b6
Author: Jan Holesovsky <kendy at collabora.com>
Date: Thu May 7 15:47:49 2020 +0200
formula bar: Change completeFunction() to accept string instead of index.
The 'index' is unsafe, because the set it tries to index can change in
the meantime. Instead, use the function name and search for it in the
set, to get the recent index.
Change-Id: Id2a021c32f421057c87b6f7f4fffcc1c98009acb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93666
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Andras Timar <andras.timar at collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93910
Tested-by: Jenkins
commit 2437a0907089a1937ec74a8b232867183d830c28
Author: Marco Cecchetti <marco.cecchetti at collabora.com>
Date: Mon Apr 20 13:48:06 2020 +0200
lok: calc: input bar: send number of text lines to client
Change-Id: Iec919ef11e22ae5d02009570f446064e3f7bfe01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92690
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Andras Timar <andras.timar at collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93345
Tested-by: Jenkins
commit 7e69bacc437807ef50bd769fedb6986e42a85876
Author: Marco Cecchetti <marco.cecchetti at collabora.com>
Date: Tue Feb 25 14:07:28 2020 +0100
lok: remove sum and equal buttons from the formula bar
This patch removes sum and equal buttons from the formula bar in the
lok case. A tentative to limit that to the mobile case has been done
however the formula input bar is created before than the client view
so we are not able to use the LibreOfficeKit::isMobile check.
Change-Id: Icb820a0d77eb9295046997d2f3690d7f8b39680d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89453
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Andras Timar <andras.timar at collabora.com>
commit 9ec1d1d4fca4cde2ddd0f207a08dacf906070f73
Author: Marco Cecchetti <marco.cecchetti at collabora.com>
Date: Wed Feb 12 15:01:19 2020 +0100
lok: formula bar: send whole function list
Change-Id: Ibbd142652f3190387700f820e56c494b61bfa658
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93341
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar at collabora.com>
commit 0469cdc945908a7c478d2ca715b0412d1e75c1e0
Author: Marco Cecchetti <marco.cecchetti at collabora.com>
Date: Mon Apr 20 21:26:26 2020 +0200
lok: set device form factor of the client on view creation
This patch allows the lok core to know about the device form facor of
the client requesting the creation of new view, immediately instead of
a later time.
When a new view is needed a "DeviceFormFactor" parameter is forwarded
to lo_documentLoadWithOptions and doc_createViewWithOptions from the
client.
This parameter can have one of the following values: 'desktop',
'tablet','mobile' and it is used to set a global variable accessible
by SfxLokHelper::setDeviceFormFactor and
SfxLokHelper::getDeviceFormFactor.
This global variable is retrived in the SfxViewShell constructor for
setting SfxViewShell::maLOKDeviceFormFactor attribute.
In SfxViewShell we have the following 3 methods:
- bool isLOKDesktop()
- bool isLOKTablet()
- bool isLOKMobilePhone()
which replace the following boolean functions:
- comphelper::LibreOfficeKit::isTablet
- comphelper::LibreOfficeKit::::isMobilePhone
Change-Id: I9b36f354278df8c216fcb90f6a9da8256ec9c1e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93340
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar at collabora.com>
commit 2bfbc4d4c83954bb46d0dc34e2838cefa62cf5a2
Author: Muhammet Kara <muhammet.kara at collabora.com>
Date: Thu Apr 16 23:01:54 2020 +0300
Move uno:Text param from core to online - core part
Change-Id: Idf51a688a868c2d140fcf5eb54e1bfdefc3690b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92394
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Muhammet Kara <muhammet.kara at collabora.com>
(cherry picked from commit d9a0e2fe5bf95bf0bfba424a3625d7f952884932)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92304
Tested-by: Jenkins
commit 2267db07cdd258dc774271fc19e068562a944f6f
Author: Mert Tumer <mert.tumer at collabora.com>
Date: Tue Apr 14 18:19:09 2020 +0300
send state changes of .uno:NumberFormatDecimal command to LOK
Change-Id: I7872c0a0c123865c77d3aa8937775116368f1ffa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92203
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Andras Timar <andras.timar at collabora.com>
(cherry picked from commit 2f6cbb67099edde535a81e7b0a32c1418805d6d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92290
Tested-by: Jenkins
commit c24c7a846a2e1586004cef2d67d819d4cf79546e
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Sun Mar 1 14:08:20 2020 -0500
editeng: lok: send cursor visibility event when restoring update mode
When the default text is removed from a TextBox within a slide,
the cursor visibility is inadvertendly set to false and never
restored (because the LOK notification is disabled due to treating
the ShowCursor during SetUpdateMode as an activation of the TextBox,
and that is supressed to avoid messing up the cursor when creating
a new view).
We add a new flag to SetUpdateMode to flag whether this is an
activation or we are restoring a previously active window (TextBox)
due to a temporary disabling (to clear the default text).
Four unit-tests added not just to check and validate the fix,
but to also simulate two different ways of entering edit mode,
first by single-clicking on the text and then double-clicking
outside the text, but within the TextBox.
Change-Id: Icaaabc2a897f614f5ce162b71fadccff22ecda02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90301
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Miklos Vajna <vmiklos at collabora.com>
(cherry picked from commit 6b84dfabbb5f6930f9ac582f8c1dd9f467fd068c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90298
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
commit 526581b6a935a98ac2f04ab062420faaf8caa6cb
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date: Wed Feb 26 16:03:47 2020 +0100
change SAL_WARN to SAL_INFO when language is not set
Change this, so we don't fill the console with warnings.
Change-Id: I089113207be99b50b15cf292cae3e929f9edff26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89556
Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
Tested-by: Andras Timar <andras.timar at collabora.com>
(cherry picked from commit af17b2cd26a1e36edf0b995f81a2e0757086dad1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89676
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar at collabora.com>
commit 5677b442a2385c21e747eaaf337f1a64d7b59076
Author: Muhammet Kara <muhammet.kara at collabora.com>
Date: Mon Feb 24 17:03:12 2020 +0300
lok: Set default text for new text box on mobile
Change-Id: I0b6056e9dbf5fb81d092092cc183b05120b95d70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89352
Reviewed-by: Jan Holesovsky <kendy at collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89710
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara at collabora.com>
commit 4d9bd71951bbcff9f5a5b5107898c86e23e0247d
Author: Muhammet Kara <muhammet.kara at collabora.com>
Date: Mon Feb 24 16:04:37 2020 +0300
lok: Create Text boxes directly
Change-Id: I281d4648d0e91f74d6f0f5880945d8e7e8659efe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89344
Reviewed-by: Jan Holesovsky <kendy at collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89709
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara at collabora.com>
commit b5a522a0d52db3974caf7ff2fe07c0dc41373fc9
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date: Mon Feb 24 08:07:12 2020 +0100
Fix currency symbol selection in Calc on mobile
In LOK we use one language identifier for both - UI language and
the locale used. This is a problem when we determine that we a
language for UI is not available and fall-back to the default
"en-US" langauge, which also changes the locale. This introduces
a separate variable that stores the language tag for the locale
independently to the language.
Another problem is that in some cases we don't reset the staticly
initialized data, when the new document is loaded, which is on
the other hand used to define which currency symbol is used as
SYSTEM locale. That can in some cases select the wrong currency
symbol even when we changed the locale to something else. This fix
introduces a reset function, which is triggered on every document
load.
Change-Id: I55c7f467600a832895f94346f8bf11a6ef6a1e49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89320
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Andras Timar <andras.timar at collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89343
Tested-by: Jenkins
commit 83bee181d933b2c1ce0f186808365c78dbe25e65
Author: Jan Holesovsky <kendy at collabora.com>
Date: Fri Feb 21 18:45:20 2020 +0100
android: Hardcode the 'double-tap' in case of the native app.
We know we are mobile, so why bother... We could go even further, and
do that directly in the comphelper, but that would need more testing I
guess.
Change-Id: Ia371d42fe0e31b5c6f17313fbf6baad4c256cbe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89236
Tested-by: Michael Meeks <michael.meeks at collabora.com>
Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89695
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar at collabora.com>
commit 1b8bc87f89d7fc67bb7906ab4f0a6622121b65a6
Author: Jan Holesovsky <kendy at collabora.com>
Date: Tue Feb 11 21:41:12 2020 +0100
android: Don't show the multiline toggle in the formula input bar on phones.
The interaction there currently distorts the view and occupies too much
space anyway.
Change-Id: I093432dcfc223e4ea8b0f5a3cc45368f90c3cc0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88477
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Jan Holesovsky <kendy at collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88481
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar at collabora.com>
commit 208491052f597bec8c16db9f467f07836c364551
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date: Wed Jan 29 12:44:30 2020 +0100
lok: preserve mouse event logic position and use in calc
When clicking in online Calc any of the charts, shapes (and
other objects), sometimes the cell underneath is selected
instead. The problem is that the object is not correctly
recognised to be hit.
From lok we get the mouse event position in logic coordinates,
which we usually can just use in writer and impress. In calc
however we need the coordinates in pixels, so we transform them
before sending the mouse event to calc. Still calc also uses
common SdrObjects (chart, shapes,...), which operate in logic
coordinates. So in case of SdrObject we need to convert the
coordniates back from pixel to logic again, which causes
problems because conversion doesn't have access to the displaying
conditions on an stateless online client.
OTOH we already had the correct logic coordinates, and we can just
send them along. This is what this change does. It adds an optional
maLogicPosition to MouseEvent, which is filled with logic position
if those is known.
Change-Id: I26f6466085baf613850b5861e368f22cad7c1d26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87681
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>
commit aa8c235386dd4075cd25ec38f7a09eb1e7877b32
Author: Jan Holesovsky <kendy at collabora.com>
Date: Wed Jan 29 10:51:49 2020 +0100
android lok: Correct the hint in the slides from click to double-tap.
Change-Id: I71744dc48f50115c9b4245ac2c81a6431ecbdce6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87678
Reviewed-by: Jan Holesovsky <kendy at collabora.com>
Tested-by: Jenkins
commit 84a6fb2367ac2bf3d2d1763cf7c1a246c11870b7
Author: Muhammet Kara <muhammet.kara at collabora.com>
Date: Sat Jan 25 04:10:38 2020 +0300
lok: Add LOK_CALLBACK_STATE_CHANGED for uno:Orientation
Change-Id: Iab3aaf742bdb9fc4b9c5875fee7d769fa0581eeb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87370
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Aron Budea <aron.budea at collabora.com>
Tested-by: Aron Budea <aron.budea at collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88451
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar at collabora.com>
commit b838a1ae614d8a76ba8a01c18e5dc47fb943ae40
Author: Jan Holesovsky <kendy at collabora.com>
Date: Fri Jan 17 18:02:05 2020 +0100
lok formula input: Don't show un-needed elements with the LOK active.
Change-Id: I82effbdd48dab5b9de2cd05859e74e5c1027a4df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86991
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Jan Holesovsky <kendy at collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87063
Tested-by: Jenkins
commit 94272d23190cd4fcf6984c9deb323bd9cf957971
Author: Muhammet Kara <muhammet.kara at collabora.com>
Date: Mon Jan 13 23:42:54 2020 +0300
lok: Unlock chart contollers after insertion on mobile view
The chart controllers were locked until the dialog finishes
its execution, but at some point, dialog is disabled for mobile
view, and seems like it was forgotten to unlock the controllers.
Change-Id: Ib1e5799f5c84ef8b3ebc0f538909b4f8b586ff1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86716
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89708
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara at collabora.com>
commit c54b1995e983e000f6abc9152fb67e604ced8026
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Wed Dec 18 10:20:56 2019 -0500
sfx2: tolerate missing LOKNotifier on FloatingWindow hide
It seems the assumption is that if we get to hide state
then we must have initialized properly and set a LOKNotifier.
But this seems not to always hold, for whatever reason.
Here we are more forgiving if we don't have LOKNotifier.
Change-Id: Id21ec83489776f34228dd31f63e711b0dd77af55
Reviewed-on: https://gerrit.libreoffice.org/85401
Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
(cherry picked from commit 25d8db8598ac54fe3ef1d6f40076ff19db87cd2f)
Reviewed-on: https://gerrit.libreoffice.org/85686
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
commit 5123f606f654be54a40785ca081eaadc5421d378
Author: Jan Holesovsky <kendy at collabora.com>
Date: Mon Dec 16 17:50:57 2019 +0100
android: Don't crash when double-tapping a text box.
Here we were accessing the notification from a destructor; so avoid that
when the pDoc is already being destructed.
Reviewed-on: https://gerrit.libreoffice.org/85235
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Jan Holesovsky <kendy at collabora.com>
(cherry picked from commit 589147c64804adc5ceba895510559e2b6806d467)
Reviewed-on: https://gerrit.libreoffice.org/85246
Tested-by: Jenkins
Change-Id: I686bc9acf66788bfed6cf478fc7a1646ca8fd259
commit f6869e462a0de414396440b4e5934121b283f990
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Tue Jul 23 19:11:36 2019 -0400
desktop: unit-test to check SpellDialog works in multiple views
Unfortunately, this isn't fully functional, but
didn't want to lose the effort. The problem is
that there is no proper config for languages
in the unit-tests. So even when we set the
language explicitly, it still doesn't apply
to the SpellCheckerDispatcher, which is
where it matters. This seems to be because
the config is not properly propagated and
broadcast. Below is the stacktrace as
works on desktop. During the unittest
the Broadcaster has no change listener
for LngSvcMgr, so SpellCheckerDispatcher::SetServiceList
doesn't get called.
#0 0x00007f47f3fed7e6 in SpellCheckerDispatcher::SetServiceList(com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<rtl::OUString> const&)
(this=0x5589de40e7a0, rLocale=..., rSvcImplNames=uno::Sequence of length 1 = {...}) at /home/ash/prj/master/linguistic/source/spelldsp.cxx:795
#1 0x00007f47f3fcc0ad in LngSvcMgr::Notify(com::sun::star::uno::Sequence<rtl::OUString> const&) (this=0x5589de43b4e0, rPropertyNames=uno::Sequence of length 4 = {...})
at /home/ash/prj/master/linguistic/source/lngsvcmgr.cxx:826
#2 0x00007f47fa2d3c8d in utl::ConfigItem::CallNotify(com::sun::star::uno::Sequence<rtl::OUString> const&) (this=0x5589de43b530, rPropertyNames=uno::Sequence of length 4 = {...})
at /home/ash/prj/master/unotools/source/config/configitem.cxx:181
#3 0x00007f47fa2d3946 in utl::ConfigChangeListener_Impl::changesOccurred(com::sun::star::util::ChangesEvent const&) (this=0x5589de464b90, rEvent=...)
at /home/ash/prj/master/unotools/source/config/configitem.cxx:143
#4 0x00007f47e273bb61 in configmgr::Broadcaster::send() (this=0x7ffcc604c5b0) at /home/ash/prj/master/configmgr/source/broadcaster.cxx:182
#5 0x00007f47e277f002 in configmgr::RootAccess::commitChanges() (this=0x5589dd557400) at /home/ash/prj/master/configmgr/source/rootaccess.cxx:171
#6 0x00007f47fa2d80e3 in utl::ConfigItem::ReplaceSetProperties(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
(this=0x5589dd5571b0, rNode="ServiceManager/SpellCheckerList", rValues=uno::Sequence of length 4 = {...}) at /home/ash/prj/master/unotools/source/config/configitem.cxx:1025
#7 0x00007f47fa339983 in SvtLinguConfig::ReplaceSetProperties(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
(this=0x7ffcc604cb40, rNode="ServiceManager/SpellCheckerList", rValues=uno::Sequence of length 4 = {...}) at /home/ash/prj/master/unotools/source/config/lingucfg.cxx:847
#8 0x00007f47f3fcb88f in LngSvcMgr::UpdateAll() (this=0x5589de43b4e0) at /home/ash/prj/master/linguistic/source/lngsvcmgr.cxx:765
#9 0x00007f47f3fc9caa in LngSvcMgr::LngSvcMgr() (this=0x5589de43b4e0) at /home/ash/prj/master/linguistic/source/lngsvcmgr.cxx:438
#10 0x00007f47f3fd3baf in LngSvcMgr_CreateInstance(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory> const&) ()
at /home/ash/prj/master/linguistic/source/lngsvcmgr.cxx:1967
#11 0x00007f4800e9656b in cppu::OSingleFactoryHelper::createInstanceEveryTime(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x5589de3ccfc8, xContext=
uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630) at /home/ash/prj/master/cppuhelper/source/factory.cxx:149
#12 0x00007f4800e96790 in cppu::OSingleFactoryHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)
(this=0x5589de3ccfc8, xContext=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630) at /home/ash/prj/master/cppuhelper/source/factory.cxx:175
#13 0x00007f4800e97107 in cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)
(this=0x5589de3ccf60, xContext=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630) at /home/ash/prj/master/cppuhelper/source/factory.cxx:374
#14 0x00007f4800eebc8f in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool)
(this=0x5589dbd2f030, context=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630, singletonRequest=false) at /home/ash/prj/master/cppuhelper/source/servicemanager.cxx:667
#15 0x00007f4800eee587 in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)
(this=0x5589dbcbaaf0, aServiceSpecifier="com.sun.star.linguistic2.LinguServiceManager", Context=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630)
at /home/ash/prj/master/cppuhelper/source/servicemanager.cxx:991
#16 0x00007f4800776778 in com::sun::star::linguistic2::LinguServiceManager::create(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)
(the_context=uno::Reference to (cppu::ComponentContext *) 0x5589dbcca630)
at /home/ash/prj/master/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/linguistic2/LinguServiceManager.hpp:38
#17 0x00007f4800772d51 in GetLngSvcMgr_Impl() () at /home/ash/prj/master/editeng/source/misc/unolingu.cxx:66
#18 0x00007f4800773449 in SpellDummy_Impl::GetSpell_Impl() (this=0x5589dd82f420) at /home/ash/prj/master/editeng/source/misc/unolingu.cxx:217
#19 0x00007f4800773614 in SpellDummy_Impl::isValid(rtl::OUString const&, short, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
(this=0x5589dd82f420, rWord="a", nLanguage=1033, rProperties=empty uno::Sequence) at /home/ash/prj/master/editeng/source/misc/unolingu.cxx:249
#20 0x00007f48006ae4c2 in ImpEditEngine::DoOnlineSpelling(ContentNode*, bool, bool) (this=0x5589de195060, pThisNodeOnly=0x0, bSpellAtCursorPos=false, bInterruptible=true)
at /home/ash/prj/master/editeng/source/editeng/impedit4.cxx:2306
#21 0x00007f480067d0d2 in ImpEditEngine::OnlineSpellHdl(Timer*) (this=0x5589de195060) at /home/ash/prj/master/editeng/source/editeng/impedit3.cxx:322
(cherry picked from commit 4f77bd94028a140133814d735c0425bbd0de4839)
Reviewed-on: https://gerrit.libreoffice.org/85007
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
(cherry picked from commit 66c1f6bee6f463786540b2e73d52f35461063589)
Reviewed-on: https://gerrit.libreoffice.org/85683
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
Change-Id: Iffef03502c78311427aa8883739678120cc84931
commit 229fb719cd869aad36ba9bccd2e361180e0d9599
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Sun Dec 15 21:12:17 2019 -0500
sfx2: sidebar: new .uno commands to show and hide sidebars
Change-Id: I9afba5eec855d6de590086736177b543d52d3b20
Reviewed-on: https://gerrit.libreoffice.org/85192
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
commit 3f34eb6d9c78538066ef3b25154bcb41e07b751f
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Thu Dec 12 01:38:02 2019 -0500
sfx2: sidebar: publish created notification on Mobile too
Reviewed-on: https://gerrit.libreoffice.org/85011
Reviewed-by: Jan Holesovsky <kendy at collabora.com>
Tested-by: Jan Holesovsky <kendy at collabora.com>
(cherry picked from commit 50af967b731495be6645f065fd11b9ad832a654a)
Change-Id: I59e5db039a6c1f29cb13e7c77a782659dbfb6894
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85786
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
commit 846dc98f51ed21ad1db97dce285a6b789839f287
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Wed Dec 11 12:23:08 2019 -0500
sfx2: sidebar: notify mobile when the sidebar closes
Change-Id: Idb05346a9ccc8690cad566b74ec86d5fdd3bfb35
Reviewed-on: https://gerrit.libreoffice.org/84973
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
commit 81bd5d98b3e29d8c9872d90e170fd5812bf2d14d
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Wed May 29 23:33:25 2019 -0400
vcl: sfx2: LOK: Support per-view popup windows
While we do support multiple views, there is only
one state for popup/floating windows, that also
includes the dialogs open and related windows/data.
This adds support to allow each view to have its own
popups and state, thus allowing multiple users to
interact with the dialogs independently of one
another.
(cherry picked from commit b50c341a53911f1d725947a4d8d3d2f782c94079)
Change-Id: I3786a561ca6ca113ad12425bdb491e5a30bd1a28
Reviewed-on: https://gerrit.libreoffice.org/82440
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/85221
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
commit 9533249c5a905e123ee041f884ca2ea20e92474b
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Sun Dec 8 12:36:58 2019 -0500
sidebar: sensible line and page sizes and invalidate
Change-Id: Icf60480a47d7c93bad44f6457bb05af332e63c6d
Reviewed-on: https://gerrit.libreoffice.org/84718
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
commit 003b295d7bfa1248d2443d38b7887cdbffb558b8
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Wed Dec 4 08:19:22 2019 -0500
LOK: don't send LOK notifications while switching views
Changing the active view is done for virtually every
LOK API, and in some cases simply changing the view
results in a flurry of notifications that themselves
caues further API calls that need to change the view.
This moves the disabling of callbacks during setView
to SfxLokHelper to make sure no view gets any
notifications. This is needed because even when
we disable notifications for the current view,
the _other_ view(s) can still get notified as they
lose their frame.
Change-Id: Ia88a58d6a1162e48c40f4c4ce73c40ecb2c1fb7e
Reviewed-on: https://gerrit.libreoffice.org/84417
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
Tested-by: Ashod Nakashian <ashnakash at gmail.com>
commit c09344d3191423828c5f14f4bf9fd7eb03e78b6f
Author: Szymon Kłos <szymon.klos at collabora.com>
Date: Thu Dec 12 09:34:54 2019 +0100
Use INVALID_POOL_ITEM instead of magic number
Change-Id: I44fdc602563164944bee40848b13de0c0c62e4f7
Reviewed-on: https://gerrit.libreoffice.org/85019
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>
commit 84cee9cb44a443e21400c347370a8f36c8131ee3
Author: Szymon Kłos <szymon.klos at collabora.com>
Date: Wed Dec 11 14:54:56 2019 +0100
Avoid crash when no uno name available
Change-Id: I81895e68d6fda46bec0cc3bca2da63901d3fed4c
Reviewed-on: https://gerrit.libreoffice.org/84950
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>
commit b5b9b94e86f64b4f925a689763e9c758f35a0cc5
Author: Szymon Kłos <szymon.klos at collabora.com>
Date: Tue Dec 3 17:31:08 2019 +0100
jsdialogs: make possible to use on multiple mobile devices
Change-Id: I1f7867dfd15e423f10622b3cec17ed8039d23c49
Reviewed-on: https://gerrit.libreoffice.org/84367
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>
commit 86acea5fe0ae76add684a1c4e7a1c5b8a26437c1
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Tue Dec 3 09:23:27 2019 -0500
sidebar: always trigger LOK notifications on resize
This is critical for the Mobile Wizard, which
refreshes by pushing, not pulling (following invalidations).
Change-Id: Ie75c2f5c07798fa89c21901d6d0233c42768ea8d
Reviewed-on: https://gerrit.libreoffice.org/84359
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
Tested-by: Ashod Nakashian <ashnakash at gmail.com>
commit 36604a74f153c37f95e930adab803772aa79cbad
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Sun Nov 24 09:56:02 2019 -0500
sidebar: do not emit unnecessary created notifications
This also breaks a potentially recursive cycle where
each 'created' notification requests a re-rendering,
which triggers view change (when more than one view
is open on the doc), which triggers a frame change,
which resets the sidebar, causing a 'created'
notification, thereby starting the cycle anew.
Change-Id: I1aafe7f45871748afb393fa55c357037215e6c33
Reviewed-on: https://gerrit.libreoffice.org/83629
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
commit 5343d4c314295e39ec5c4a7683f0c09bf3ce64d2
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Fri Nov 22 21:07:21 2019 -0500
sidebar: reset the LOKNotifier when the ViewShell changes
The ViewShell (which implements the LOKNotifier interface)
changes during the lifetime of the SidebarDockingWindow.
This is extremely problematic, because we assign the
LOKNotifier to a window, and use it to emit notifications
to the LOKit clients. When the ViewShell changes, a window
(the SidebarDockingWindow in this case) may end up using
an old ViewShell instance, which may have just been destroyed.
Now we properly reset the LOKNotifier to make sure we are
using the current ViewShell at all times. This is still
not ideal, since we may use the wrong ViewShell to send
out notifications, but we can't control that as we are at
the mercy of the mechanism that changes the current ViewShell.
This also removes obsolete flags to control which
document-types supported sidebar, as well as other misc
cleanups.
Change-Id: Ic208f64596a39feb7354958cf4d5e1e033d87b5b
Reviewed-on: https://gerrit.libreoffice.org/83627
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
commit c6f93e65148f8eaf437ddfe97cffce4568911ead
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Wed Oct 30 06:12:26 2019 -0400
sidebars: add JSDialog support to sidebars
Currently the JSDialog path is only for mobile
and we use the passive notifications for desktop
Online.
Change-Id: I5d26fee9475ede665f269ca1f7b582455be08e50
Reviewed-on: https://gerrit.libreoffice.org/81754
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
More information about the Libreoffice-commits
mailing list