[Libreoffice-commits] core.git: vcl/source

[Luboš Luňák (via logerrit)]

 vcl/source/app/help.cxx |   17 -----------------
 1 file changed, 17 deletions(-)

New commits:
commit 17bdb844bba68cd0cb54312bd9ea1037850db5fd
Author:     Luboš Luňák <l.lunak at collabora.com>
AuthorDate: Wed May 27 15:21:25 2020 +0200
Commit:     Luboš Luňák <l.lunak at collabora.com>
CommitDate: Thu May 28 10:05:47 2020 +0200

    do not explicitly invalidate window under a tooltip (tdf#131419)
    
    It doesn't really make sense, since tooltips are separate windows,
    any repaints will be normally handled by the windowing system.
    And native (=handled by a specific VCL backend) tooltips do not
    do this either.
    This avoids an off-by-one error somewhere, seen in tdf#131419.
    
    Change-Id: Ie22dad61d021807aa15efdde7dbb77274460d575
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94976
    Tested-by: Jenkins
    Reviewed-by: Luboš Luňák <l.lunak at collabora.com>

diff --git a/vcl/source/app/help.cxx b/vcl/source/app/help.cxx
index 54f0dbbfb4d3..ebe7588c562f 100644
--- a/vcl/source/app/help.cxx
+++ b/vcl/source/app/help.cxx
@@ -518,11 +518,6 @@ void ImplShowHelpWindow( vcl::Window* pParent, sal_uInt16 nHelpWinStyle, QuickHe
                 ((pHelpWin->GetHelpArea() != rHelpArea) && aHelpData.mbRequestingHelp);
             if (bUpdate)
             {
-                vcl::Window * pWindow = pHelpWin->GetParent()->ImplGetFrameWindow();
-                tools::Rectangle aInvRect( pHelpWin->GetWindowExtentsRelative( pWindow ) );
-                if( pHelpWin->IsVisible() )
-                    pWindow->Invalidate( aInvRect );
-
                 pHelpWin->SetHelpText( rHelpText );
                 // approach mouse position
                 ImplSetHelpWindowPos( pHelpWin, nHelpWinStyle, nStyle, rScreenPos, rHelpArea );
@@ -564,18 +559,6 @@ void ImplDestroyHelpWindow(ImplSVHelpData& rHelpData, bool bUpdateHideTime)
     VclPtr<HelpTextWindow> pHelpWin = rHelpData.mpHelpWin;
     if( pHelpWin )
     {
-        vcl::Window * pParent = pHelpWin->GetParent();
-        if( pParent )
-        {
-            VclPtr<vcl::Window> pWindow( pParent->ImplGetFrameWindow() );
-            if( pWindow )
-            {
-                // find out screen area covered by system help window
-                tools::Rectangle aInvRect( pHelpWin->GetWindowExtentsRelative( pWindow ) );
-                if( pHelpWin->IsVisible() )
-                    pWindow->Invalidate( aInvRect );
-            }
-        }
         rHelpData.mpHelpWin = nullptr;
         rHelpData.mbKeyboardHelp = false;
         pHelpWin->Hide();