[Libreoffice-commits] core.git: sw/inc sw/source

[Bjoern Michaelsen (via logerrit)]

 sw/inc/calbck.hxx              |    3 ---
 sw/source/core/attr/calbck.cxx |    7 -------
 2 files changed, 10 deletions(-)

New commits:
commit cec71744c5fc20e9aedd444372348b562b6c6b79
Author:     Bjoern Michaelsen <bjoern.michaelsen at libreoffice.org>
AuthorDate: Mon Nov 2 22:26:06 2020 +0100
Commit:     Bjoern Michaelsen <bjoern.michaelsen at libreoffice.org>
CommitDate: Wed Nov 4 21:27:12 2020 +0100

    remove SwClient::ModifyNotifcation, now unused
    
    ... and there was much rejoicing.
    
    Change-Id: Ib7ed5a897f2a1e7490462eb47578a8efd22a669e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105233
    Tested-by: Jenkins
    Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen at libreoffice.org>

diff --git a/sw/inc/calbck.hxx b/sw/inc/calbck.hxx
index ed719037fa9d..ee142fd871fe 100644
--- a/sw/inc/calbck.hxx
+++ b/sw/inc/calbck.hxx
@@ -145,9 +145,6 @@ public:
     // mba: IMHO this method should be pure virtual
     // DO NOT USE IN NEW CODE! use SwClientNotify instead.
     virtual void Modify(const SfxPoolItem*, const SfxPoolItem*);
-    // controlled access to Modify method
-    // mba: this is still considered a hack and it should be fixed; the name makes grep-ing easier
-    void ModifyNotification(const SfxPoolItem*, const SfxPoolItem*);
     // when overriding this, you MUST call SwClient::SwClientModify() in the override!
     virtual void SwClientNotify(const SwModify&, const SfxHint& rHint) override;
 
diff --git a/sw/source/core/attr/calbck.cxx b/sw/source/core/attr/calbck.cxx
index efa764b8783c..63e5496e821f 100644
--- a/sw/source/core/attr/calbck.cxx
+++ b/sw/source/core/attr/calbck.cxx
@@ -113,13 +113,6 @@ void SwClient::SwClientNotify(const SwModify&, const SfxHint& rHint)
     }
 };
 
-void SwClient::ModifyNotification(const SfxPoolItem* pOldValue, const SfxPoolItem* pNewValue)
-{
-    SwModify aFallbackMod;
-    auto pMod = dynamic_cast<SwModify*>(this);
-    SwClientNotify(pMod ? *pMod : aFallbackMod, sw::LegacyModifyHint(pOldValue, pNewValue));
-}
-
 void SwClient::StartListeningToSameModifyAs(const SwClient& other)
 {
     if(other.m_pRegisteredIn)