[Libreoffice-commits] core.git: uitest/test_main.py

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Thu Nov 5 09:18:14 UTC 2020


 uitest/test_main.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 91c5642bf0ee48ff91181d779c3a84c768f340df
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Nov 5 08:19:51 2020 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Nov 5 10:17:33 2020 +0100

    Make order of UITest *.py test file processing deterministic
    
    ...hoping that this can prevent issues like the one seen with
    1b0eb76eb1787d9d9fbd7a7a73ee8ae47b62dc33 "tdf#137617: sc: Add UItest" followed
    by d1232ee6b5e5cc3c811ef3ad72c83e9bd884bfe3 "uitest: reset formula syntax back
    to Calc A1" (i.e., where the first commit's Gerrit Jenkins build had apparently
    only succeeded because it happened to run the tests in one specific order,
    different from the order in which later, failing builds ran it)
    
    Change-Id: I4f1b5ada10d60e77b45a0edeb89069fe9376b63e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105325
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/uitest/test_main.py b/uitest/test_main.py
index 3b2de433ca24..1904ecbb3476 100644
--- a/uitest/test_main.py
+++ b/uitest/test_main.py
@@ -37,7 +37,7 @@ def usage():
 
 def find_test_files(dir_path):
     valid_files = []
-    for f in os.listdir(dir_path):
+    for f in sorted(os.listdir(dir_path)):
         file_path = os.path.join(dir_path, f)
 
         # don't go through the sub-directories


More information about the Libreoffice-commits mailing list