[Libreoffice-commits] core.git: l10ntools/inc l10ntools/source
Julien Nabet (via logerrit)
logerrit at kemper.freedesktop.org
Sat Nov 14 18:17:00 UTC 2020
l10ntools/inc/helper.hxx | 4 ++++
l10ntools/source/helper.cxx | 6 ++++++
2 files changed, 10 insertions(+)
New commits:
commit 457d76327a57303124804a201d58b52ba23ccefe
Author: Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Sat Nov 14 09:58:49 2020 +0100
Commit: Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Sat Nov 14 19:16:12 2020 +0100
loplugin:stringviewparam (l10ntools)
Change-Id: I9102a00e19af87de4f666d1759551be3af311fe0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105828
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
diff --git a/l10ntools/inc/helper.hxx b/l10ntools/inc/helper.hxx
index a6eed4ff59d3..ff81f5792105 100644
--- a/l10ntools/inc/helper.hxx
+++ b/l10ntools/inc/helper.hxx
@@ -28,7 +28,11 @@ OString escapeAll(
const OString& rText, const OString& rUnEscaped, const OString& rEscaped );
/// Unescape all given character in the text
OString unEscapeAll(
+#ifdef DEBUG
const OString& rText, const OString& rEscaped, const OString& rUnEscaped );
+#else
+ const OString& rText, const OString& rEscaped, std::string_view rUnEscaped );
+#endif
/// Convert special characters to XML entity references
OString QuotHTML( const OString &rString );
diff --git a/l10ntools/source/helper.cxx b/l10ntools/source/helper.cxx
index b842755c27f6..22f5cc5df506 100644
--- a/l10ntools/source/helper.cxx
+++ b/l10ntools/source/helper.cxx
@@ -31,9 +31,15 @@ OString escapeAll(
OString unEscapeAll(
+#ifdef DEBUG
const OString& rText, const OString& rEscaped, const OString& rUnEscaped)
+#else
+ const OString& rText, const OString& rEscaped, std::string_view rUnEscaped)
+#endif
{
+#ifdef DEBUG
assert( rEscaped.getLength() == 2*rUnEscaped.getLength() );
+#endif
OStringBuffer sReturn;
const sal_Int32 nLength = rText.getLength();
for ( sal_Int32 nIndex = 0; nIndex < nLength; ++nIndex )
More information about the Libreoffice-commits
mailing list