[Libreoffice-commits] core.git: sw/source

[Jim Raykowski (via logerrit)]

 sw/source/core/frmedt/feshview.cxx |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit 5110cca39cc55c8977b81f7b09873e626144b29b
Author:     Jim Raykowski <raykowj at gmail.com>
AuthorDate: Mon Nov 16 08:09:11 2020 -0900
Commit:     Jim Raykowski <raykowj at gmail.com>
CommitDate: Tue Nov 17 19:30:49 2020 +0100

    tdf#130629 Don't add object insert undo twice
    
    Change-Id: I074afd4397b6fc4631bd00655de56b8a154d7dff
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105955
    Tested-by: Jenkins
    Tested-by: Xisco Fauli <xiscofauli at libreoffice.org>
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>
    Reviewed-by: Jim Raykowski <raykowj at gmail.com>

diff --git a/sw/source/core/frmedt/feshview.cxx b/sw/source/core/frmedt/feshview.cxx
index ee81434e9b59..767e4e7f16e8 100644
--- a/sw/source/core/frmedt/feshview.cxx
+++ b/sw/source/core/frmedt/feshview.cxx
@@ -3137,7 +3137,12 @@ void SwFEShell::CreateDefaultShape( SdrObjKind eSdrObjectKind, const tools::Rect
         }
         SdrPageView* pPageView = pDrawView->GetSdrPageView();
         SdrCreateView::SetupObjLayer(pPageView, pDrawView->GetActiveLayer(), pObj);
+        // switch undo off or this combined with ImpEndCreate will cause two undos
+        // see comment made in SwFEShell::EndCreate (we create our own undo-object!)
+        const bool bUndo(GetDoc()->GetIDocumentUndoRedo().DoesUndo());
+        GetDoc()->GetIDocumentUndoRedo().DoUndo(false);
         pDrawView->InsertObjectAtView(pObj, *pPageView);
+        GetDoc()->GetIDocumentUndoRedo().DoUndo(bUndo);
     }
     ImpEndCreate();
 }