[Libreoffice-commits] core.git: helpcontent2
Henrik Karlsson (via logerrit)
logerrit at kemper.freedesktop.org
Thu Nov 26 11:03:42 UTC 2020
helpcontent2 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit c0372945539d68e3f9034d4ec7d8aec67d9066fd
Author: Henrik Karlsson <hk.henrik at gmail.com>
AuthorDate: Thu Nov 26 12:03:03 2020 +0100
Commit: Gerrit Code Review <gerrit at gerrit.libreoffice.org>
CommitDate: Thu Nov 26 12:03:03 2020 +0100
Update git submodules
* Update helpcontent2 from branch 'master'
to e95e2a6d94ac5c08d3821f3da198a7982b7d0af8
- Update redirects to replace the url rather than navigate to a new one
Current links from outside (like the wiki) will cause excess history
entries when clicking the https://help.libreoffice.org/ link,
breaking the back button.
See the example of the visited pages below. Ideally only the referring
page and the final page should be in the history, allowing the user to
navigate back.
1. https://help.libreoffice.org/Main_Page
2. https://help.libreoffice.org/ - 302 redirect
3. https://help.libreoffice.org/help.html - window.location.href
4. https://help.libreoffice.org/latest/index.html - window.location.href
5. https://help.libreoffice.org/latest/en-US/text/shared/05/new_help.html?&DbPAR=WRITER&System=UNIX
The second 302 redirect is fine as it simply replaces the history. The
two window.location.href assigments however should be replaced with
window.location.replace.
Change-Id: I6fbe7141de87c939aa816fdfc2fe5255e9792e0b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106429
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot at libreoffice.org>
diff --git a/helpcontent2 b/helpcontent2
index 51923f0e54c4..e95e2a6d94ac 160000
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 51923f0e54c44e9fa8a3d35092938f5a228256fd
+Subproject commit e95e2a6d94ac5c08d3821f3da198a7982b7d0af8
More information about the Libreoffice-commits
mailing list