[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - helpcontent2

Henrik Karlsson (via logerrit) logerrit at kemper.freedesktop.org
Fri Nov 27 00:14:43 UTC 2020


 helpcontent2 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b48c89372154fd8d74b740898ba688c265df7314
Author:     Henrik Karlsson <hk.henrik at gmail.com>
AuthorDate: Fri Nov 27 01:14:05 2020 +0100
Commit:     Gerrit Code Review <gerrit at gerrit.libreoffice.org>
CommitDate: Fri Nov 27 01:14:05 2020 +0100

    Update git submodules
    
    * Update helpcontent2 from branch 'libreoffice-7-1'
      to d24008f863730b7aa52758df11f605e01941eaa2
      - Update redirects to replace the url rather than navigate to a new one
    
        Current links from outside (like the wiki) will cause excess history
        entries when clicking the https://help.libreoffice.org/ link,
        breaking the back button.
    
        See the example of the visited pages below. Ideally only the referring
        page and the final page should be in the history, allowing the user to
        navigate back.
    
        1. https://help.libreoffice.org/Main_Page
        2. https://help.libreoffice.org/ - 302 redirect
        3. https://help.libreoffice.org/help.html - window.location.href
        4. https://help.libreoffice.org/latest/index.html - window.location.href
        5. https://help.libreoffice.org/latest/en-US/text/shared/05/new_help.html?&DbPAR=WRITER&System=UNIX
    
        The second 302 redirect is fine as it simply replaces the history. The
        two window.location.href assigments however should be replaced with
        window.location.replace.
    
        Change-Id: I6fbe7141de87c939aa816fdfc2fe5255e9792e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106429
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot at libreoffice.org>
        (cherry picked from commit e95e2a6d94ac5c08d3821f3da198a7982b7d0af8)
        Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106680
        Reviewed-by: Adolfo Jayme Barrientos <fitojb at ubuntu.com>

diff --git a/helpcontent2 b/helpcontent2
index c07e293f4827..d24008f86373 160000
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c07e293f482776df8f57cf1b7aea014c81ee2438
+Subproject commit d24008f863730b7aa52758df11f605e01941eaa2


More information about the Libreoffice-commits mailing list