[Libreoffice-commits] core.git: basic/qa

[Andreas Heinisch (via logerrit)]

 basic/qa/basic_coverage/test_cverr_method.vb |   26 +++++++++-----------------
 1 file changed, 9 insertions(+), 17 deletions(-)

New commits:
commit 698e5d54182d96a1fd0c3b864ba0e618f82dd1f1
Author:     Andreas Heinisch <andreas.heinisch at yahoo.de>
AuthorDate: Mon Oct 5 12:20:50 2020 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Tue Oct 6 17:17:55 2020 +0200

    tdf#123025 - fixed broken tests for cverr method
    
    Change-Id: I44eb44107a24207764da24b4e01b407570342013
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103956
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/basic/qa/basic_coverage/test_cverr_method.vb b/basic/qa/basic_coverage/test_cverr_method.vb
index f74445c20c6a..9bc8b4f953f1 100644
--- a/basic/qa/basic_coverage/test_cverr_method.vb
+++ b/basic/qa/basic_coverage/test_cverr_method.vb
@@ -7,26 +7,18 @@
 '
 
 Function doUnitTest as Integer
-    ' CVERR
-    If (CVerr(100) <> 100) Then
-        doUnitTest = 0
-    Else
-        doUnitTest = 1
-    End If
 
-    ' tdf#79426 - passing an error object to a function
-    if ( TestCVErr( CVErr( 2 ) ) <> 2 ) Then
-        doUnitTest = 0
-    Else
-        doUnitTest = 1
-    End If
+    doUnitTest = 0
 
+    ' CVERR
+    If (CVerr(100) <> 100) Then Exit Function
+    ' tdf#79426 - passing an error object to a function
+    If (TestCVErr(CVErr(2)) <> 2) Then Exit Function
     ' tdf#79426 - test with Error-Code 448 ( ERRCODE_BASIC_NAMED_NOT_FOUND )
-    if ( TestCVErr( CVErr( 448 ) ) <> 448 ) Then
-        doUnitTest = 0
-    Else
-        doUnitTest = 1
-    End If
+    If (TestCVErr(CVErr(448)) <> 448) Then Exit Function
+
+    doUnitTest = 1
+
 End Function
 
 Function TestCVErr(vErr As Variant)