[Libreoffice-commits] core.git: bin/lint-ui.py

[Noel (via logerrit)]

 bin/lint-ui.py |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit b03708252bb50dd2fbca0f82fa170e6d90816b82
Author:     Noel <noelgrandin at gmail.com>
AuthorDate: Wed Oct 7 13:36:48 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Wed Oct 7 18:43:07 2020 +0200

    lint-ui: add exclusion
    
    Change-Id: Idae99392593c87c7d3b36e426c8d1363434786be
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104059
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/bin/lint-ui.py b/bin/lint-ui.py
index 0518bd5a7da4..84916229c9a0 100755
--- a/bin/lint-ui.py
+++ b/bin/lint-ui.py
@@ -122,7 +122,10 @@ def check_menu_buttons(root):
         images = button.findall("./property[@name='image']")
         assert(len(labels) <= 1)
         if len(labels) < 1 and len(images) < 1:
-            lint_assert(False, "No label in GtkMenuButton with id = '" + button.attrib['id'] + "'", button)
+            if sys.argv[1] == "vcl/uiconfig/ui/combobox.ui": and button.attrib['id'] == "overlaybutton":
+                pass
+            else:
+                lint_assert(False, "No label in GtkMenuButton with id = '" + button.attrib['id'] + "'", button)
 
 def check_check_buttons(root):
     radios = [element for element in root.findall('.//object') if element.attrib['class'] == 'GtkCheckButton']