[Libreoffice-commits] core.git: sc/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Sat Oct 10 18:01:22 UTC 2020


 sc/source/ui/app/scmod.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fe107c1a32b999af409e902cffb6f26c11818203
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sat Oct 10 14:03:01 2020 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sat Oct 10 20:00:36 2020 +0200

    cid#1467974 Dereference before null check
    
    Change-Id: Ic612cb420934764c42cca08d09915bdc8332cb2f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104171
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 688e52d3f54a..35212b04a138 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -343,7 +343,7 @@ void ScModule::Execute( SfxRequest& rReq )
             {
                 bool bSet;
                 const SfxPoolItem* pItem;
-                if (pReqArgs->HasItem(FN_PARAM_1, &pItem))
+                if (pReqArgs && pReqArgs->HasItem(FN_PARAM_1, &pItem))
                     bSet = static_cast<const SfxBoolItem*>(pItem)->GetValue();
                 else if ( pReqArgs && SfxItemState::SET == pReqArgs->GetItemState( nSlot, true, &pItem ) )
                     bSet = static_cast<const SfxBoolItem*>(pItem)->GetValue();


More information about the Libreoffice-commits mailing list