[Libreoffice-commits] core.git: sd/qa

[Xisco Fauli (via logerrit)]

 sd/qa/unit/data/pptx/bnc887230.pptx |binary
 sd/qa/unit/export-tests-ooxml1.cxx  |   18 ++++++++++++++++++
 2 files changed, 18 insertions(+)

New commits:
commit 659c56b06a658950c82af9789376ff0c1858a787
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Tue Oct 13 13:26:53 2020 +0200
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Tue Oct 13 15:28:26 2020 +0200

    bnc#887230: sd_export_ooxml1: Add unittest
    
    Bisection of tdf#137367 points to the commit fixing bnc#887230
    Make sure we don't regress here
    
    Change-Id: I54877ca5fae8c7074baf1211ec983c1bc1961f59
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104232
    Tested-by: Xisco Fauli <xiscofauli at libreoffice.org>
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/sd/qa/unit/data/pptx/bnc887230.pptx b/sd/qa/unit/data/pptx/bnc887230.pptx
new file mode 100644
index 000000000000..7d4a23578545
Binary files /dev/null and b/sd/qa/unit/data/pptx/bnc887230.pptx differ
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx b/sd/qa/unit/export-tests-ooxml1.cxx
index f1b8bcca5b6d..db64dc374481 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -56,6 +56,7 @@ class SdOOXMLExportTest1 : public SdModelTestBaseXML
 public:
     void testFdo90607();
     void testTdf127237();
+    void testBnc887230();
     void testBnc870233_1();
     void testBnc870233_2();
     void testN828390_4();
@@ -103,6 +104,7 @@ public:
 
     CPPUNIT_TEST(testFdo90607);
     CPPUNIT_TEST(testTdf127237);
+    CPPUNIT_TEST(testBnc887230);
     CPPUNIT_TEST(testBnc870233_1);
     CPPUNIT_TEST(testBnc870233_2);
     CPPUNIT_TEST(testN828390_4);
@@ -218,6 +220,22 @@ void SdOOXMLExportTest1::testTdf127237()
     xDocShRef->DoClose();
 }
 
+void SdOOXMLExportTest1::testBnc887230()
+{
+    ::sd::DrawDocShellRef xDocShRef = loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/pptx/bnc887230.pptx"), PPTX);
+    xDocShRef = saveAndReload( xDocShRef.get(), PPTX );
+
+    const SdrPage *pPage = GetPage( 1, xDocShRef );
+
+    const SdrTextObj *pObj = dynamic_cast<SdrTextObj *>( pPage->GetObj( 0 ) );
+    // Without the fix in place, this test would have failed with
+    //- Expected: 255
+    //- Actual  : 13421823
+    checkFontAttributes<Color, SvxColorItem>( pObj, Color(0x0000ff) );
+
+    xDocShRef->DoClose();
+}
+
 void SdOOXMLExportTest1::testBnc870233_1()
 {
     ::sd::DrawDocShellRef xDocShRef = loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/pptx/bnc870233_1.pptx"), PPTX);