[Libreoffice-commits] core.git: sd/source

Noel (via logerrit) logerrit at kemper.freedesktop.org
Fri Oct 16 17:19:33 UTC 2020


 sd/source/filter/ppt/pptinanimations.cxx |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

New commits:
commit 648d9892e8a85606c060e050e31251357dcff44b
Author:     Noel <noelgrandin at gmail.com>
AuthorDate: Fri Oct 16 12:51:09 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Oct 16 19:18:51 2020 +0200

    remove thread-unsafe static buffer
    
    Change-Id: I13aa210ed6120ff9d8e541d53eceba0304ba28d9
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104424
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sd/source/filter/ppt/pptinanimations.cxx b/sd/source/filter/ppt/pptinanimations.cxx
index 3d17237ba67b..826765ab7185 100644
--- a/sd/source/filter/ppt/pptinanimations.cxx
+++ b/sd/source/filter/ppt/pptinanimations.cxx
@@ -3007,15 +3007,14 @@ void AnimationImporter::dump( const PropertySet& rSet )
                 case DFF_ANIM_PRESS_CLASS_OLE_ACTION:       pMode = "oleaction"; break;
                 case DFF_ANIM_PRESS_CLASS_MEDIACALL:        pMode = "mediacall"; break;
                 default:
-                {
-                    static char buffer[128];
-                    sprintf( buffer, "%" SAL_PRIdINT32, nPresetClass );
-                    pMode = buffer;
-                }
+                    pMode = nullptr;
                 break;
                 }
 
-                fprintf(mpFile, " class=\"%s\"", pMode);
+                if (pMode)
+                    fprintf(mpFile, " class=\"%s\"", pMode);
+                else
+                    fprintpf(mpFile, " class =\"%" SAL_PRIdINT32 "\"", nPresetClass);
                 bKnown = true;
             }
         }


More information about the Libreoffice-commits mailing list