[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - cui/source

Mike Kaganski (via logerrit) logerrit at kemper.freedesktop.org
Tue Sep 1 11:37:07 UTC 2020


 cui/source/dialogs/about.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c6ccf624dad2095aff50d2b939fd3b0b7743ca68
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Mon Aug 31 15:37:33 2020 +0200
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Sep 1 13:36:35 2020 +0200

    Fix warning condition
    
    Missed that I needed to reverse the condition when replacing OSL_ENSURE
    with SAL_WARN_IF in 37f452bc2beeae9b4648013a3bf4f2e8b56c0c85.
    
    Thanks Julien for noticing!
    
    Change-Id: Id24216e11ca970b05aac40a09ed02cdbb4cf9865
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101678
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>
    Tested-by: Jenkins
    (cherry picked from commit ca7caf212a90b6e4290782159cbdbb36e4538f19)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101684
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx
index 917e5f4bd30d..99245b94b3ed 100644
--- a/cui/source/dialogs/about.cxx
+++ b/cui/source/dialogs/about.cxx
@@ -157,7 +157,7 @@ OUString AboutDialog::GetVersionString() {
 OUString AboutDialog::GetBuildString()
 {
   OUString sBuildId(utl::Bootstrap::getBuildIdData(""));
-  SAL_WARN_IF(!sBuildId.isEmpty(), "cui.dialogs", "No BUILDID in bootstrap file");
+  SAL_WARN_IF(sBuildId.isEmpty(), "cui.dialogs", "No BUILDID in bootstrap file");
 
   return sBuildId;
 }


More information about the Libreoffice-commits mailing list