[Libreoffice-commits] core.git: svtools/source

[Caolán McNamara (via logerrit)]

 svtools/source/control/valueset.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6a9e01ed889e92772e32ad5255fc60bd6dd7ee2a
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Sep 1 10:45:52 2020 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Sep 1 22:13:37 2020 +0200

    tdf#136319 do logging before calling handler which might destroy the valueset
    
    though doing this logging always when ~100% of the time there is noone
    listening seems wasteful
    
    Change-Id: Ib18462b70136ac52a4b9340a3a0890b4f97a4593
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101839
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/svtools/source/control/valueset.cxx b/svtools/source/control/valueset.cxx
index 9fb267e7b6cf..280d8eaff848 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -165,8 +165,8 @@ void ValueSet::ImplDeleteItems()
 
 void ValueSet::Select()
 {
-    maSelectHdl.Call( this );
     collectUIInformation(OStringToOUString(GetDrawingArea()->get_buildable_name(),RTL_TEXTENCODING_UTF8) , OStringToOUString(GetDrawingArea()->get_help_id(),RTL_TEXTENCODING_UTF8) , OUString::number(GetSelectedItemId()));
+    maSelectHdl.Call( this );
 }
 
 void ValueSet::UserDraw( const UserDrawEvent& )