[Libreoffice-commits] core.git: include/vcl vcl/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Sep 2 07:36:16 UTC 2020


 include/vcl/window.hxx       |   17 -----------------
 vcl/source/window/window.cxx |   12 ------------
 2 files changed, 29 deletions(-)

New commits:
commit e2da259b5733a36f8b4f934869f02ea7ee5163db
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Sep 1 14:44:25 2020 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Sep 2 09:35:35 2020 +0200

    SetCallHandlersOnInputDisabled is newly unused
    
    Change-Id: I4225ce786b83f44178a477ac034d8f8f5198159e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101852
    Tested-by: Caolán McNamara <caolanm at redhat.com>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 24b74328dc63..458b225f26d8 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -983,23 +983,6 @@ public:
     */
     void                                AlwaysDisableInput( bool bAlways, bool bChild = true );
 
-    /** usually event handlers (see AddEventListener and AddChildEventListener)
-    are not called on disabled, modal or input disabled windows. There are however rare cases
-    in which one wants a Window or rather one of its Control subclasses to
-    not evaluate events but still react to those events externally. In these
-    rare cases call SetCallHandlersOnInputDisabled( true ) to have your handler
-    called anyway.
-
-    Currently only mouse events get this special treatment.
-
-    Use this sparingly, chances are if you want to use it you're working around
-    the real problem.
-
-    @param bCall
-    Enable/Disable calling event handlers for this disabled, modal or input disabled window.
-    This call is implicitly done recursively for possible child windows.
-    */
-    void                                SetCallHandlersOnInputDisabled( bool bCall );
     /** get state of SetCallHandlersOnInputDisabled
 
     @returns whether handlers are called regardless of input enabled state
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 523dc5bdde77..e06a8cf1e961 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -2484,18 +2484,6 @@ void Window::Enable( bool bEnable, bool bChild )
         ImplGenerateMouseMove();
 }
 
-void Window::SetCallHandlersOnInputDisabled( bool bCall )
-{
-    mpWindowImpl->mbCallHandlersDuringInputDisabled = bCall;
-
-    VclPtr< vcl::Window > pChild = mpWindowImpl->mpFirstChild;
-    while ( pChild )
-    {
-        pChild->SetCallHandlersOnInputDisabled( bCall );
-        pChild = pChild->mpWindowImpl->mpNext;
-    }
-}
-
 bool Window::IsCallHandlersOnInputDisabled() const
 {
     return mpWindowImpl->mbCallHandlersDuringInputDisabled;


More information about the Libreoffice-commits mailing list