[Libreoffice-commits] core.git: sw/qa

Miklos Vajna (via logerrit) logerrit at kemper.freedesktop.org
Thu Sep 3 07:17:48 UTC 2020


 sw/qa/uitest/writer_tests/trackedChanges.py |    2 --
 1 file changed, 2 deletions(-)

New commits:
commit a658ece9f9fa308084c3e0f4662dda7afb9a0879
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Wed Sep 2 21:51:02 2020 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Thu Sep 3 09:17:13 2020 +0200

    UITest_writer_tests: don't assert exact page count at test_tdf135018() end
    
    For example
    
    cd sw; make -sr UITest_writer_tests UITEST_TEST_NAME="trackedChanges.trackedchanges.test_tdf135018"
    
    fails for me like this:
    
        self.assertEqual(18, document.CurrentController.PageCount)
    AssertionError: 18 != 17
    
    This is likely because the test document is not carefully preparted to
    only use bundled fonts. The test mentions that the primary point is to
    make sure we don't crash, so just give up on asserting the exact page
    number.
    
    Change-Id: I212c02995fd487526d4e2fab7b351d383f9b8459
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101980
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/sw/qa/uitest/writer_tests/trackedChanges.py b/sw/qa/uitest/writer_tests/trackedChanges.py
index 53a3e2f356a3..601801ebe6ae 100644
--- a/sw/qa/uitest/writer_tests/trackedChanges.py
+++ b/sw/qa/uitest/writer_tests/trackedChanges.py
@@ -254,8 +254,6 @@ class trackedchanges(UITestCase):
         xcloseBtn = xTrackDlg.getChild("close")
         xcloseBtn.executeAction("CLICK", tuple())
 
-        self.assertEqual(18, document.CurrentController.PageCount)
-
         self.ui_test.close_doc()
 
 # vim: set shiftwidth=4 softtabstop=4 expandtab:


More information about the Libreoffice-commits mailing list