[Libreoffice-commits] core.git: compilerplugins/clang

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Thu Sep 3 14:57:44 UTC 2020


 compilerplugins/clang/stringstatic.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit ea061cbe1bfb912c692473bb5e2755b3e15ac375
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Sep 3 14:51:10 2020 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Sep 3 16:57:06 2020 +0200

    Fix check for member Decl's name
    
    ...as some members like
    
      OUString::operator std::u16string_view()
    
    don't have a name
    
    Change-Id: I3ac9bbc43cdf899d4ab0483a95f00097f4b6f20a
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102001
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/compilerplugins/clang/stringstatic.cxx b/compilerplugins/clang/stringstatic.cxx
index c5753445fc34..fcc984b0515b 100644
--- a/compilerplugins/clang/stringstatic.cxx
+++ b/compilerplugins/clang/stringstatic.cxx
@@ -187,7 +187,8 @@ bool StringStatic::VisitMemberExpr(MemberExpr const * expr)
         return true;
     if (potentialVars.count(varDecl) == 0)
         return true;
-    if (expr->getMemberDecl()->getName() != "pData") {
+    auto const id = expr->getMemberDecl()->getIdentifier();
+    if (id == nullptr || id->getName() != "pData") {
         return true;
     }
     excludeVars.insert(varDecl);


More information about the Libreoffice-commits mailing list