[Libreoffice-commits] core.git: sw/qa

Daniel Arato (NISZ) (via logerrit) logerrit at kemper.freedesktop.org
Thu Sep 3 17:36:30 UTC 2020


 sw/qa/extras/ooxmlexport/ooxmlexport6.cxx |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 0be6e21857f868d85049fca2c8e02fc5e8802120
Author:     Daniel Arato (NISZ) <arato.daniel at nisz.hu>
AuthorDate: Mon Aug 31 13:30:26 2020 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Thu Sep 3 19:35:50 2020 +0200

    tdf#129423 sw: export-only tests, part 10
    
    Convert some unit tests from "export" tests to "export only".
    Remove nullptr checks on parseExport's return value to make
    the tests fail if parsing fails for any reason.
    
    Change-Id: I0edb7988431b9e8cf5959dcb5753301fa4a0c210
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101721
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
index fa09ebbfbc27..120a8db1d3bb 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
@@ -119,13 +119,10 @@ DECLARE_OOXMLEXPORT_TEST(testDmlTextshape, "dml-textshape.docx")
     CPPUNIT_ASSERT_EQUAL(sal_Int32(-4727), xShape->getPosition().Y);
 }
 
-DECLARE_OOXMLEXPORT_TEST(testDmlTextshapeB, "dml-textshapeB.docx")
+// testDmlTextshapeB was only made export-only because as an import-export test it failed for an unknown reason
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testDmlTextshapeB, "dml-textshapeB.docx")
 {
     uno::Reference<container::XIndexAccess> xGroup(getShape(1), uno::UNO_QUERY);
-    xmlDocUniquePtr pXmlDocument = parseExport("word/document.xml");
-    if (!pXmlDocument)
-        return;
-
     uno::Reference<drawing::XShape> xShape(xGroup->getByIndex(3), uno::UNO_QUERY);
     // Connector was incorrectly shifted towards the top left corner, X was 192, Y was -5743.
     CPPUNIT_ASSERT_EQUAL(sal_Int32(3778), xShape->getPosition().X);


More information about the Libreoffice-commits mailing list