[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - libreofficekit/qa

[Tor Lillqvist (via logerrit)]

 libreofficekit/qa/unit/tiledrendering.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit ddbabe1c09f4863865983cc93321b5e24b1d18bb
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Fri Sep 4 11:30:09 2020 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Fri Sep 4 11:07:01 2020 +0200

    Remove an odd CPPUNIT_ASSERT(0)
    
    The unit test that code is in isn't even run currently (commented out
    in Module_libreofficekit.mk), so no harm in not making it fail
    intentionally. (The commit message of the commit that added the test
    with the intentionally always failing assertion does not tell what the
    idea was.)
    
    Change-Id: I93407723ce10c77366e6f7f96df93d86f214f497
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102029
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tor Lillqvist <tml at collabora.com>

diff --git a/libreofficekit/qa/unit/tiledrendering.cxx b/libreofficekit/qa/unit/tiledrendering.cxx
index d0c128fb3a34..ee935cf82cdb 100644
--- a/libreofficekit/qa/unit/tiledrendering.cxx
+++ b/libreofficekit/qa/unit/tiledrendering.cxx
@@ -447,7 +447,6 @@ void TiledRenderingTest::testMultiKeyInput(Office *pOffice)
     // get track changes ?
     char *values = pDocument->getCommandValues(".uno:AcceptTrackedChanges");
     std::cerr << "Values: '" << values << "'\n";
-    CPPUNIT_ASSERT(0);
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(TiledRenderingTest);