[Libreoffice-commits] core.git: chart2/source

[Balazs Varga (via logerrit)]

 chart2/source/controller/main/ChartController_Window.cxx |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit c10d5854b5427ad1bfffc00e77a9306c99c78c63
Author:     Balazs Varga <balazs.varga991 at gmail.com>
AuthorDate: Thu Sep 3 14:53:19 2020 +0200
Commit:     László Németh <nemeth at numbertext.org>
CommitDate: Mon Sep 7 12:45:01 2020 +0200

    tdf#136430 Fix chart crash trying to move data labels
    
    with arrow keys.
    
    Change-Id: I357c320406d9f044b12b1289aa0f88045001c283
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102002
    Tested-by: László Németh <nemeth at numbertext.org>
    Reviewed-by: László Németh <nemeth at numbertext.org>

diff --git a/chart2/source/controller/main/ChartController_Window.cxx b/chart2/source/controller/main/ChartController_Window.cxx
index 9e00bf784550..a7b6ee840b55 100644
--- a/chart2/source/controller/main/ChartController_Window.cxx
+++ b/chart2/source/controller/main/ChartController_Window.cxx
@@ -1765,6 +1765,12 @@ bool ChartController::impl_moveOrResizeObject(
 {
     bool bResult = false;
     bool bNeedResize = ( eType == CENTERED_RESIZE_OBJECT );
+    ObjectType eObjectType = ObjectIdentifier::getObjectType(rCID);
+
+    /*TODO: Move data label objects with arrow-keys,
+    in that case we have to use CustomLabelPosition instead of RelativePosition!*/
+    if( eObjectType == OBJECTTYPE_DATA_LABEL )
+        return bResult;
 
     uno::Reference< frame::XModel > xChartModel( getModel() );
     uno::Reference< beans::XPropertySet > xObjProp(
@@ -1824,7 +1830,6 @@ bool ChartController::impl_moveOrResizeObject(
             if( bNeedResize )
                 eActionType = ActionDescriptionProvider::ActionType::Resize;
 
-            ObjectType eObjectType = ObjectIdentifier::getObjectType( rCID );
             UndoGuard aUndoGuard( ActionDescriptionProvider::createDescription(
                     eActionType, ObjectNameProvider::getName( eObjectType )), m_xUndoManager );
             {