[Libreoffice-commits] core.git: basic/source

[Arnaud Versini (via logerrit)]

 basic/source/runtime/dllmgr-none.cxx |    6 ++----
 basic/source/runtime/dllmgr.hxx      |    2 ++
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 85232a2e5711e811bdba615f541c08ed10045ee5
Author:     Arnaud Versini <arnaud.versini at libreoffice.org>
AuthorDate: Sun Sep 6 15:49:57 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Sep 7 15:27:51 2020 +0200

    BASIC : no need for a DLL manager impl on non windows systems
    
    Change-Id: I4bee1ec99b69b42b7eea540b04511cbafe5fbd0c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102106
    Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/basic/source/runtime/dllmgr-none.cxx b/basic/source/runtime/dllmgr-none.cxx
index 7ca7e5131e3e..bce18495b3bb 100644
--- a/basic/source/runtime/dllmgr-none.cxx
+++ b/basic/source/runtime/dllmgr-none.cxx
@@ -32,8 +32,6 @@
 
 #include "dllmgr.hxx"
 
-struct SbiDllMgr::Impl {};
-
 namespace {
 
 // Overcome the mess of Currency vs. custom types etc.
@@ -107,8 +105,8 @@ ErrCode SbiDllMgr::Call(
 
 void SbiDllMgr::FreeDll(SAL_UNUSED_PARAMETER OUString const &) {}
 
-SbiDllMgr::SbiDllMgr(): impl_(new Impl) {}
+SbiDllMgr::SbiDllMgr() = default;
 
-SbiDllMgr::~SbiDllMgr() {}
+SbiDllMgr::~SbiDllMgr() = default;
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/basic/source/runtime/dllmgr.hxx b/basic/source/runtime/dllmgr.hxx
index ce79c54797f3..08927843a98d 100644
--- a/basic/source/runtime/dllmgr.hxx
+++ b/basic/source/runtime/dllmgr.hxx
@@ -42,9 +42,11 @@ public:
     void FreeDll(OUString const & library);
 
 private:
+#ifdef _WIN32
     struct Impl;
 
     std::unique_ptr< Impl > impl_;
+#endif
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */