[Libreoffice-commits] core.git: chart2/source compilerplugins/clang

[Noel Grandin (via logerrit)]

 chart2/source/inc/ModifyListenerCallBack.hxx          |    4 +--
 compilerplugins/clang/unnecessaryvirtual-dead.results |    6 +---
 compilerplugins/clang/unnecessaryvirtual.results      |   24 +++++-------------
 3 files changed, 11 insertions(+), 23 deletions(-)

New commits:
commit b0b0162656fbfe502ace2e02df7e58afa4ccc6b1
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Sep 7 14:49:24 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Sep 7 18:18:57 2020 +0200

    loplugin:unnecessaryvirtual
    
    Change-Id: I596ef2603560f521386e273b6f0fb2f672db56d7
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102171
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/chart2/source/inc/ModifyListenerCallBack.hxx b/chart2/source/inc/ModifyListenerCallBack.hxx
index f53f10fbb9ad..e9167079e982 100644
--- a/chart2/source/inc/ModifyListenerCallBack.hxx
+++ b/chart2/source/inc/ModifyListenerCallBack.hxx
@@ -33,12 +33,12 @@ without becoming a XModifyListener yourself
 
 class ModifyListenerCallBack_impl;
 
-class OOO_DLLPUBLIC_CHARTTOOLS ModifyListenerCallBack
+class OOO_DLLPUBLIC_CHARTTOOLS ModifyListenerCallBack final
 {
 public:
     explicit ModifyListenerCallBack( const Link<void*,void>& rCallBack );
 
-    virtual ~ModifyListenerCallBack();
+    ~ModifyListenerCallBack();
 
     void startListening( const ::com::sun::star::uno::Reference< ::com::sun::star::util::XModifyBroadcaster >& xBroadcaster );
     SAL_DLLPRIVATE void stopListening();
diff --git a/compilerplugins/clang/unnecessaryvirtual-dead.results b/compilerplugins/clang/unnecessaryvirtual-dead.results
index 7f23e8490075..e43137eaec81 100644
--- a/compilerplugins/clang/unnecessaryvirtual-dead.results
+++ b/compilerplugins/clang/unnecessaryvirtual-dead.results
@@ -8,15 +8,13 @@ canvas/inc/base/graphicdevicebase.hxx:318
     void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XVetoableChangeListener> &,)
 include/basegfx/utils/unopolypolygon.hxx:94
     void basegfx::unotools::UnoPolyPolygon::modifying()const
-include/vcl/toolkit/treelistbox.hxx:512
-    void SvTreeListBox::PreparePaint(class OutputDevice &,class SvTreeListEntry &,)
 sc/source/core/opencl/formulagroupcl.cxx:1069
     void sc::opencl::(anonymous namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
-slideshow/source/engine/animationfactory.cxx:593
+slideshow/source/engine/animationfactory.cxx:616
     void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch()
 vcl/inc/salframe.hxx:145
     void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
-vcl/inc/salinst.hxx:199
+vcl/inc/salinst.hxx:200
     void SalInstance::releaseMainThread()
 vcl/inc/salmenu.hxx:81
     void SalMenu::RemoveMenuBarButton(unsigned short,)
diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results
index 57fadbf8b7f0..9280ca91b736 100644
--- a/compilerplugins/clang/unnecessaryvirtual.results
+++ b/compilerplugins/clang/unnecessaryvirtual.results
@@ -206,13 +206,15 @@ canvas/inc/base/spritecanvasbase.hxx:162
     void canvas::SpriteCanvasBase::moveSprite(const class rtl::Reference<class canvas::Sprite> &,const class basegfx::B2DPoint &,const class basegfx::B2DPoint &,const class basegfx::B2DVector &,)
 canvas/inc/base/spritecanvasbase.hxx:174
     void canvas::SpriteCanvasBase::updateSprite(const class rtl::Reference<class canvas::Sprite> &,const class basegfx::B2DPoint &,const class basegfx::B2DRange &,)
-canvas/inc/rendering/icolorbuffer.hxx:44
+canvas/inc/rendering/icolorbuffer.hxx:43
     void canvas::IColorBuffer::~IColorBuffer()
 canvas/inc/rendering/irendermodule.hxx:59
     void canvas::IRenderModule::~IRenderModule()
 canvas/inc/rendering/isurface.hxx:34
     void canvas::ISurface::~ISurface()
-chart2/source/inc/WeakListenerAdapter.hxx:57
+chart2/source/inc/ModifyListenerCallBack.hxx:41
+    void chart::ModifyListenerCallBack::~ModifyListenerCallBack()
+chart2/source/inc/WeakListenerAdapter.hxx:56
     void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,)
 extensions/source/dbpilots/unoautopilot.hxx:81
     class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const
@@ -296,18 +298,6 @@ include/vcl/customweld.hxx:42
     class rtl::OUString weld::CustomWidgetController::GetHelpText()const
 include/vcl/toolkit/dialog.hxx:96
     void Dialog::set_content_area(class VclBox *,)
-include/vcl/toolkit/treelistbox.hxx:417
-    void SvTreeListBox::SelectHdl()
-include/vcl/toolkit/treelistbox.hxx:418
-    void SvTreeListBox::DeselectHdl()
-include/vcl/toolkit/treelistbox.hxx:419
-    _Bool SvTreeListBox::DoubleClickHdl()
-include/vcl/toolkit/treelistbox.hxx:512
-    void SvTreeListBox::PreparePaint(class OutputDevice &,class SvTreeListEntry &,)
-include/vcl/toolkit/treelistbox.hxx:584
-    void SvTreeListBox::CheckButtonHdl()
-include/vcl/toolkit/treelistbox.hxx:677
-    class VclPtr<class PopupMenu> SvTreeListBox::CreateContextMenu()
 include/vcl/weld.hxx:95
     void weld::Widget::set_visible(_Bool,)
 sc/source/core/opencl/formulagroupcl.cxx:1061
@@ -400,9 +390,9 @@ slideshow/source/engine/activities/activitiesfactory.cxx:536
     void slideshow::internal::(anonymous namespace)::ValuesActivity::endAnimation()
 slideshow/source/engine/activities/activitiesfactory.cxx:581
     void slideshow::internal::(anonymous namespace)::ValuesActivity::performEnd()
-slideshow/source/engine/animationfactory.cxx:593
+slideshow/source/engine/animationfactory.cxx:616
     void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch()
-slideshow/source/engine/animationfactory.cxx:596
+slideshow/source/engine/animationfactory.cxx:619
     void slideshow::internal::(anonymous namespace)::GenericAnimation::start(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,)
 slideshow/source/inc/shape.hxx:221
     void slideshow::internal::Shape::setIsForeground(const _Bool,)
@@ -422,7 +412,7 @@ vcl/inc/salframe.hxx:194
     void SalFrame::Flush(const class tools::Rectangle &,)
 vcl/inc/salinst.hxx:89
     _Bool SalInstance::SVMainHook(int *,)
-vcl/inc/salinst.hxx:199
+vcl/inc/salinst.hxx:200
     void SalInstance::releaseMainThread()
 vcl/inc/salmenu.hxx:80
     _Bool SalMenu::AddMenuBarButton(const struct SalMenuButtonItem &,)