[Libreoffice-commits] online.git: cypress_test/integration_tests

[Tamás Zolnai (via logerrit)]

 cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js |   16 +++++-----
 1 file changed, 9 insertions(+), 7 deletions(-)

New commits:
commit f0ad3cad533e58f8b8c1e658a0fb65231d995431
Author:     Tamás Zolnai <tamas.zolnai at collabora.com>
AuthorDate: Mon Sep 14 11:40:56 2020 +0200
Commit:     Tamás Zolnai <tamas.zolnai at collabora.com>
CommitDate: Mon Sep 14 12:15:19 2020 +0200

    cypress: fix random failure of date / time field insertion test.
    
    Change-Id: Icc7d28ab1c436d4dc7fc32c7a6ecb3fdc98281d9
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102656
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>

diff --git a/cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js b/cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js
index 5ef4f658a..6adf0cbef 100644
--- a/cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js
+++ b/cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js
@@ -19,7 +19,7 @@ describe('Impress insertion wizard.', function() {
 		helper.afterAll(testFileName);
 	});
 
-	function selectionShouldBeTextShape() {
+	function selectionShouldBeTextShape(checkShape) {
 		// Check that the shape is there
 		cy.get('.leaflet-pane.leaflet-overlay-pane svg')
 			.should(function(svg) {
@@ -27,8 +27,10 @@ describe('Impress insertion wizard.', function() {
 				expect(svg[0].getBBox().height).to.be.greaterThan(0);
 			});
 
-		cy.get('.leaflet-pane.leaflet-overlay-pane svg g.Page g')
-			.should('be.visible');
+		if (checkShape) {
+			cy.get('.leaflet-pane.leaflet-overlay-pane svg g.Page g')
+				.should('be.visible');
+		}
 
 		// Check also that the shape is fully visible
 		// TODO: shapes are hungs out of the slide after insertion
@@ -220,7 +222,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check that the shape is there
-		selectionShouldBeTextShape();
+		selectionShouldBeTextShape(false);
 
 		// Check the text
 		impressMobileHelper.selectTextOfShape();
@@ -240,7 +242,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check that the shape is there
-		selectionShouldBeTextShape();
+		selectionShouldBeTextShape(false);
 
 		// Check the text
 		impressMobileHelper.selectTextOfShape();
@@ -260,7 +262,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check that the shape is there
-		selectionShouldBeTextShape();
+		selectionShouldBeTextShape(false);
 
 		// Check the text
 		impressMobileHelper.selectTextOfShape();
@@ -280,7 +282,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check that the shape is there
-		selectionShouldBeTextShape();
+		selectionShouldBeTextShape(false);
 
 		// Check the text
 		impressMobileHelper.selectTextOfShape();