[Libreoffice-commits] online.git: Changes to 'feature/calc-canvas2'

Jan Holesovsky (via logerrit) logerrit at kemper.freedesktop.org
Wed Sep 16 08:42:35 UTC 2020 

New branch 'feature/calc-canvas2' available with the following commits:
commit 09efef5982764b2ab7566bc4d3b327fdcc638bef
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Tue Sep 15 22:04:52 2020 +0200

    split panes: Don't expose the freeze panes buttons in the toolbar.
    
    The split panes are not modified that often, no need to have buttons to
    set that up in the toolbar.
    
    Change-Id: I9c7920f6dd57de5f507450e15fcde615ad941f1c

commit 2e2e5a7a346b46769d83332abb727f64a9499e24
Author: Pranam Lashkari <lpranam at collabora.com>
Date:   Fri Aug 21 07:44:11 2020 +0530

    leaflet: added freeze pan buttons to view menu
    
    Change-Id: I9ba7a0982b15d097e21d93a6e18289455f0f8139

commit ee2a357911dbda9c8106f27af49975793c6c79ef
Author: Pranam Lashkari <lpranam at collabora.com>
Date:   Thu Aug 20 03:47:07 2020 +0530

    leaflet: added freeze pan buttons to toolbar
    
    Change-Id: Ifb9ae58deef77397a5d5eb7c0bfd85625f1a4e74

commit 7dd235cac769ef15929c8f33e86f9ac00c130767
Author: Pranam Lashkari <lpranam at collabora.com>
Date:   Thu Aug 20 03:46:39 2020 +0530

    notebookbar: added freeze pan buttons in calc
    
    added icons too
    
    Change-Id: I913f315c2e5bfcfbf6f82677ecffe76eaf86ea2a

commit 5215552f9a4b4811f439ae6a95e18064c4728b23
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Tue Sep 15 21:36:14 2020 +0200

    split panes: No dragging of the split lines currently.
    
    It is too buggy, let's instead allow only setting of that via the menu,
    similarly to what the desktop LO does.
    
    Change-Id: I219b2535e0cbd5310fe2a3a9ebf2098536d5c175

commit a439a6336cfa0e3078b85082b652dcba63a3b0fb
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Tue Sep 15 21:33:14 2020 +0200

    split panes: No split lines at all when they are at 0 position.
    
    Change-Id: I9fee28f32acdabd4768b095a471f26e5e8e9a378

commit 187e21c5c565e6d73e9c67dc4a14027ed8855603
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Tue Sep 15 09:15:44 2020 +0200

    calc canvas: More reliable check for the desktop / mobile / tablet.
    
    Change-Id: I7b1ea581051608e020fd6e4615be9bc9b919c01f

commit f3a6075e3510305adac51ffe96c3119d2c58ebe3
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Thu Sep 10 15:35:27 2020 +0100

    calc canvas: get the right core px size of the canvas across.
    
    Change-Id: Ib079097b9d5caf707bd95b286d675791b5df9255

commit 18153819cc2405e078993f3205751713354e63a1
Author: Szymon Kłos <szymon.klos at collabora.com>
Date:   Thu Sep 10 12:47:42 2020 +0200

    Adjust splitline thickness according to zoom level
    
    Change-Id: I33c398f1545860fb2f77d9d8dcdd8f632c2603ca

commit bba82f524dc6eff18eeb752d00b85b7ad9bcd0d7
Author: Szymon Kłos <szymon.klos at collabora.com>
Date:   Wed Sep 9 15:08:20 2020 +0200

    Don't block handling of touch events
    
    This is partial revert of 901ecca313.
    Handles (Markers) 'down' handler disabled
    main TouchGesture handler what caused
    taps to be ignored. Eg. double click didn't
    enter edit mode for a Calc cell.
    
    Change-Id: Id7097e9ad513e56a71423a6d6a8ac5105c373f77

commit e16840a53354308155ff24f235e3a0d268eb9fba
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Wed Sep 9 12:02:50 2020 +0100

    calc tiles: clarify some magic.
    
    Change-Id: I2d95dd09b5640a5216e72366493ddf77541c8b73

commit dab0521fbd69f294f432831d20d4927c36f55a64
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Tue Sep 8 16:18:31 2020 +0100

    calc canvas: avoid repeated setTransform; build the right offset.
    
    Change-Id: Iab153b25fa38f27742a052ad0892e3d55c2c04cc

commit 9e9a0bd83be8e21e39c9118e228826e72f064476
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Tue Sep 8 16:03:34 2020 +0100

    calc canvas: use sub image blitting instead of clipping.
    
    Avoids thrashing the canvas rendering context / clip state.
    
    Change-Id: I547ce22a171874cd7be3a0fac50b4afc56faf084

commit f8877801831c85434f0e267706a63761d9b3445c
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Tue Sep 8 16:03:15 2020 +0100

    calc canvas: round view co-ordinates to the real pixels we need.
    
    Change-Id: I768cd9015da1f1301f3ddad242130d4eddb426d1

commit 5dbc118188f3eec3aab79ec3cd4545f2ab52f078
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Tue Sep 8 15:25:09 2020 +0100

    calc canvas: avoid lots of canvas context save/restores.
    
    Change-Id: Ib813686ef7d495e660ad8fa3b545391180b9e019

commit bfdda065a579e98bea8ca5a383f8231210a668ed
Author: Szymon Kłos <szymon.klos at collabora.com>
Date:   Tue Sep 8 13:52:33 2020 +0200

    Split lines only in the corner when set to 0
    
    Change-Id: I6192219cede2d0888ecd77236f72ff734d99d778

commit 1851763a4906a7e349bc0a55dc3ed2020987c57c
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Thu Sep 3 23:19:13 2020 +0200

    calc canvas: Preserving of the top left cell should be desktop-only.
    
    On mobile, the center of the zooming has to be according to the center
    of the pinch-to-zoom, ie. the center has to be taken into account.
    
    Change-Id: I3ba2ea90b7bac9bc1ba27f8068ea7ed6bbb4910d

commit 5834b50de26a5b89015e73484f5a0568cfffdcd1
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Tue Sep 1 21:35:35 2020 +0100

    calc canvas: paint invalid tiles until their replacement arrives.
    
    This avoids display corruption when panning, whereby stale/old
    canvas content would continue to be rendered in the 'holes'
    where invalid tiles were not rendered.
    
    Change-Id: Ic886c0924c5a930116b1437c8e0cf35726ab76a5

commit d962ce7a75d69661c5f1f0b09e07e4cfcd9eac9a
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Tue Sep 1 16:53:02 2020 +0100

    calc tiles: don't send un-necessary zoom / visible area changes.
    
    Lots of redundant zoom messages seem unhelpful.
    
    Change-Id: I944a3202739adfc89aab81902b467a4e34977202

commit 2143430a0bb0d2b450713ef76ecda39ead227b4a
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Tue Sep 1 16:24:18 2020 +0100

    calc canvas: ensure that the fraction width rounds to the pixel width.
    
    Slave CSS geometry from integral canvas pixels, don't attempt the
    reverse.
    
    Change-Id: I369ed1bea3c4a5a199192aa1e84bb4e03dcb2e94

commit 077da231fccb4953b420a84edbc7a2115c3b4c87
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Tue Sep 1 01:39:07 2020 +0200

    calc canvas: Fix occasional off-by-one error that results in a blurry canvas.
    
    The core of the fix is in _getNewPixelOrigin() where the round() behaves
    non-predictably / inconsistently with the rest of the code, causing
    random off-by-one error that shows (or not) depending on the window
    size.
    
    The biggest problem of this is that this off-by-one is then multiplied
    somewhere by the zoom factor, causing the canvas being completely
    blurry; but eventually when the user clicked into the sheet, it
    'magically' fixed itself.
    
    The rest of the changes (in setZoom()) should actually do the same thing
    as the previous code, but using existing methods, instead of computing
    the shifts manually.
    
    Change-Id: If0ecb1301b7c1e65cfe8126385ef959c584c5d16

commit f134d52b182ab81e917a3942a668c98ee81d9c91
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Fri Aug 28 16:05:04 2020 +0100

    calc tiles: connect debug to global setting.
    
    Change-Id: I0db008ac40020c9173d37969aa6c23b3a1696f79

commit a1859e0fee0f7b14a9ff66536e989b7834de9703
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Wed Aug 26 15:15:55 2020 +0200

    calc canvas: Keep the document zoom separate from the browser zoom.
    
    With this, if you increase or decrease the browser zoom, the document
    zoom still stays the same.
    
    Before this, when you had eg. 100% document zoom and 150% browser zoom
    and try to zoom out, it actually zooms in instead, because the browser's
    zoom is added to the mix; and it displays the wrong value in the
    dropdown.  Even worse, to get the 100% again, you have to choose 80% so
    that the correction for the browser zoom is added, resulting in the
    100%.
    
    We should keep both the document and browser zoom separately.  The
    questions is then whether to combine them later for the actual document
    rendering; I believe we should not, but even if we should, we cannot do
    it directly in the setZoom() method, but instead closer to the painting
    itself.
    
    Change-Id: Ib7f3d2ae8b4e6e6086f14e933b215c32326c6be6

commit 61cb443a8923da9b25308130c63fa101d506b8d8
Author: Dennis Francis <dennis.francis at collabora.com>
Date:   Tue Aug 25 12:01:51 2020 +0530

    specialize twips/core-pixels/css-pixels conversion methods
    
    Change-Id: Ifb0a67b938fdd34a06bb7e75832498d566247010

commit e97c02f415bab6238525496fb7f01d64ddd5bc9f
Author: Dennis Francis <dennis.francis at collabora.com>
Date:   Tue Aug 25 11:55:25 2020 +0530

    detect change in dpi and update zoom
    
    Change-Id: I034727a8fe8495445350648fea2422c56fda1875

commit e37089d4406f58b12fb8eb62859b23d07d2f55f6
Author: Dennis Francis <dennis.francis at collabora.com>
Date:   Tue Aug 25 11:36:03 2020 +0530

    use the main canvas dpiScale everywhere
    
    Change-Id: I2bea44a000552ce8f2fee2b0ebb5a4d162d3576f

commit f387381a091ec858f9e143682bb9f0df8c8f83c9
Author: Dennis Francis <dennis.francis at collabora.com>
Date:   Mon Aug 24 22:34:27 2020 +0530

    sheetGeometry: use exact dpiScale when canvas is used
    
    Also use the term core-pixels instead of 'device pixels' which is more
    appropriate.
    
    Change-Id: I18952393f17e0391167e0219b829be47723c5c47

commit ab29fa0828e904515662c55f2d191559c968ddcc
Author: Dennis Francis <dennis.francis at collabora.com>
Date:   Mon Aug 24 22:31:16 2020 +0530

    header canvases should resize with map-resize
    
    This is now safe as we update their contents on resize.
    
    Change-Id: Ie8b33e03e9b67de0f5c4d0e4822154032c171a70

commit 1901d68b3f0e2f16d32c1c57a5ac43159d242423
Author: Dennis Francis <dennis.francis at collabora.com>
Date:   Mon Aug 24 22:12:18 2020 +0530

    setup the header canvases in the same way as the tile-canvas
    
    All drawings to it needs to in css pixels for now, because the
    mouse/touch handlers need positions in css pixels and the HeaderInfo
    datastructure has everything in css pixels.
    
    Moving the headers to the main-canvas needs more work but this change
    will help in doing that.
    
    Change-Id: I6a19e62a67b2b42975a51bb695db300ce493ba01

commit 02f0d3268c26eb02f14dd30b0d93e88d0ce7bf0e
Author: Dennis Francis <dennis.francis at collabora.com>
Date:   Mon Aug 24 16:49:47 2020 +0530

    compute nearest zoomlevel with devpixelratio included
    
    and use this for every setZoom call.
    
    Change-Id: I37f0d7503e4087f062576bc03b13bd8155c3c994

commit 733864fa07a7fa5057faa87c44ce070977d79702
Author: Dennis Francis <dennis.francis at collabora.com>
Date:   Mon Aug 24 15:50:44 2020 +0530

    calc-canvas: make tile size fixed (256) for every device
    
    Change-Id: I4e00b8b43f73f001a8bcfc77931f5fa22982642e

commit bc5a8954819c9b2cfb7a07d1f5e29257c4647e59
Author: Dennis Francis <dennis.francis at collabora.com>
Date:   Mon Aug 24 15:34:30 2020 +0530

    use window.devicePixelRatio without rounding
    
    at least for the canvas tile layer.
    
    Change-Id: Ia830cad1fe0aaac6df03288cc1ee9e0371ef6f47

commit 06998d3ca01ff581206e2e271731d5579eae510a
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Fri Aug 21 20:43:47 2020 +0100

    Don't merge - grim hack try to get 1:1 pixels in canvas.
    
    Change-Id: I8ff3f157112295e0c6ef6743de3c878329b98adb

commit 3ccf2c4a30db762ce35dc6957569fff6a8270957
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Fri Aug 21 16:40:29 2020 +0100

    calc tiles: more debug helpers
    
    Change-Id: I24370b2a35fdfeca360cbaeb296cd2dd3a11e768

commit 8e4a4de87c5bacfe97343d1daa1c75e3e2eea882
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Fri Aug 21 15:54:50 2020 +0100

    calc tiles: share code for building bounds and panes.
    
    Avoid duplication between tileReady and paint.
    
    Change-Id: Ic3d1c22a1dbeffe1abfffd35ea0d7fbcfd5c1ccc

commit 05d919dd74356b73555aa537ad598b16a1a2ab6f
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Fri Aug 21 15:47:58 2020 +0100

    calc tiles: remove partial re-rendering for now.
    
    Drops _shiftAndPaint and _paintRects, blits are fast.
    
    Change-Id: I64779f1037784f4efbe74cdf564b5f09e13b3316

More information about the Libreoffice-commits mailing list