[Libreoffice-commits] core.git: vcl/skia

Luboš Luňák (via logerrit) logerrit at kemper.freedesktop.org
Wed Sep 23 06:45:55 UTC 2020


 vcl/skia/salbmp.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 1f5141522ffa79f2a94d0f11fa7e6008755ae6d6
Author:     Luboš Luňák <l.lunak at collabora.com>
AuthorDate: Tue Sep 22 17:13:06 2020 +0200
Commit:     Luboš Luňák <l.lunak at collabora.com>
CommitDate: Wed Sep 23 08:45:11 2020 +0200

    assert that SkiaSalBitmap mImage is not deleted if it's the only data
    
    Change-Id: Idec2e0f3e852c37b37e220ac5059ef0b6accc77a
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103205
    Tested-by: Jenkins
    Reviewed-by: Luboš Luňák <l.lunak at collabora.com>

diff --git a/vcl/skia/salbmp.cxx b/vcl/skia/salbmp.cxx
index c77b80e39bc1..d933b33e6ac2 100644
--- a/vcl/skia/salbmp.cxx
+++ b/vcl/skia/salbmp.cxx
@@ -1059,6 +1059,8 @@ void SkiaSalBitmap::EnsureBitmapUniqueData()
 void SkiaSalBitmap::ResetCachedData()
 {
     SkiaZone zone;
+    // This should never be called to drop mImage if that's the only data we have.
+    assert(mBuffer || !mImage);
     mImage.reset();
     mAlphaImage.reset();
 }


More information about the Libreoffice-commits mailing list