[Libreoffice-commits] core.git: extensions/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Sep 23 12:59:51 UTC 2020


 extensions/source/update/check/updatecheck.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 2313d99c019f27956a4d28f96c25ea2477d538b9
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Sep 23 12:27:31 2020 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Sep 23 14:59:14 2020 +0200

    cid#1466970 annotate as false positive
    
    Change-Id: I2ccb0fe70626c998fbc108464f03f1d4144e600d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103244
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/extensions/source/update/check/updatecheck.cxx b/extensions/source/update/check/updatecheck.cxx
index 348ef35faaca..485b4e140947 100644
--- a/extensions/source/update/check/updatecheck.cxx
+++ b/extensions/source/update/check/updatecheck.cxx
@@ -810,6 +810,7 @@ UpdateCheck::initialize(const uno::Sequence< beans::NamedValue >& rValues,
                 bool downloadPaused = aModel.isDownloadPaused();
 
                 enableDownload(true, downloadPaused);
+                // coverity[lock_order : FALSE] - incorrect report of lock older error with std::recursive_mutex
                 setUIState(downloadPaused ? UPDATESTATE_DOWNLOAD_PAUSED : UPDATESTATE_DOWNLOADING);
             }
 
@@ -841,7 +842,10 @@ UpdateCheck::initialize(const uno::Sequence< beans::NamedValue >& rValues,
                 if ( bDownloadAvailable )
                     setUIState( UPDATESTATE_DOWNLOAD_AVAIL );
                 else
+                {
+                    // coverity[lock_order : FALSE] - incorrect report of lock order error with std::recursive_mutex
                     setUIState(getUIState(m_aUpdateInfo));
+                }
             }
         }
     }


More information about the Libreoffice-commits mailing list