[Libreoffice-commits] core.git: sc/CppunitTest_sc_jumbosheets_test.mk

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Wed Sep 23 14:53:50 UTC 2020


 sc/CppunitTest_sc_jumbosheets_test.mk |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit d0b3e5fc81a1d1903ef220bdea8036766a17dae2
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Sep 23 15:28:15 2020 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Sep 23 16:53:11 2020 +0200

    Fix linking CppunitTest/test_sc_jumbosheets_test on Windows
    
    ...where it started to fail for me with
    
    > jumbosheets-test.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: void __cdecl SvRefBase::ReleaseRef(void)" (__imp_?ReleaseRef at SvRefBase@@QEAAXXZ) referenced in function "public: __cdecl tools::SvRef<class ScDocShell>::~SvRef<class ScDocShell>(void)" (??1?$SvRef at VScDocShell@@@tools@@QEAA at XZ)
    > workdir\LinkTarget\CppunitTest\test_sc_jumbosheets_test.dll : fatal error LNK1120: 1 unresolved externals
    
    (even though SvRefBase::ReleaseRef is defined inline in include/tools/ref.hxx;
    but virtual ~SvRefBase is not, so presumably MSVC expects to find a copy of the
    former emitted next to the latter).
    
    Change-Id: I58ae9853cbf69ea58b156ae9ddf8a0a2e1dee090
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103252
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sc/CppunitTest_sc_jumbosheets_test.mk b/sc/CppunitTest_sc_jumbosheets_test.mk
index 3f8b0c99fbe8..0bac3a9c6571 100644
--- a/sc/CppunitTest_sc_jumbosheets_test.mk
+++ b/sc/CppunitTest_sc_jumbosheets_test.mk
@@ -32,6 +32,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sc_jumbosheets_test, \
     scqahelper \
     sfx \
     test \
+    tl \
     unotest \
     vcl \
 ))


More information about the Libreoffice-commits mailing list