[Libreoffice-commits] online.git: fuzzer/data wsd/DocumentBroker.cpp

Miklos Vajna (via logerrit) logerrit at kemper.freedesktop.org
Mon Sep 28 08:51:06 UTC 2020


 fuzzer/data/crash-91bfaabb3dea7c9d496e4aa7d06c2eed2b64b49e |binary
 wsd/DocumentBroker.cpp                                     |    6 ++++++
 2 files changed, 6 insertions(+)

New commits:
commit 2b546f72dec43d8ac3bc24c1f767ceb7f617d9be
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Mon Sep 28 10:20:07 2020 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Mon Sep 28 10:50:46 2020 +0200

    document broker: handle tile request without tile cache
    
    Change-Id: I5e0006cde07a84e6553db92627fdab943ac51d04
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/103534
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>

diff --git a/fuzzer/data/crash-91bfaabb3dea7c9d496e4aa7d06c2eed2b64b49e b/fuzzer/data/crash-91bfaabb3dea7c9d496e4aa7d06c2eed2b64b49e
new file mode 100644
index 000000000..343599776
Binary files /dev/null and b/fuzzer/data/crash-91bfaabb3dea7c9d496e4aa7d06c2eed2b64b49e differ
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 909c8db1b..701aebbb9 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1744,6 +1744,12 @@ void DocumentBroker::handleTileRequest(TileDesc& tile,
     const std::string tileMsg = tile.serialize();
     LOG_TRC("Tile request for " << tileMsg);
 
+    if (!hasTileCache())
+    {
+        LOG_WRN("Tile request without a loaded document?");
+        return;
+    }
+
     TileCache::Tile cachedTile = _tileCache->lookupTile(tile);
     if (cachedTile)
     {


More information about the Libreoffice-commits mailing list