[Libreoffice-commits] online.git: ios/CollaboraOnlineWebViewKeyboardManager

Tor Lillqvist (via logerrit) logerrit at kemper.freedesktop.org
Wed Sep 30 16:36:52 UTC 2020


 ios/CollaboraOnlineWebViewKeyboardManager/CollaboraOnlineWebViewKeyboardManager.m |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 894c51d6d44bf7073d6a189d63b38f63431ae188
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Tue Sep 29 16:37:10 2020 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Wed Sep 30 18:36:33 2020 +0200

    Fix warning: block implicitly retains 'self'; explicitly mention 'self' ...
    
    ... to indicate this is intended behavior.
    
    Change-Id: Id5318bb20b8066364c5e2fd3b704b5a73bac1b42
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/103711
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tor Lillqvist <tml at collabora.com>

diff --git a/ios/CollaboraOnlineWebViewKeyboardManager/CollaboraOnlineWebViewKeyboardManager.m b/ios/CollaboraOnlineWebViewKeyboardManager/CollaboraOnlineWebViewKeyboardManager.m
index fd1bcaff3..18a1128e8 100644
--- a/ios/CollaboraOnlineWebViewKeyboardManager/CollaboraOnlineWebViewKeyboardManager.m
+++ b/ios/CollaboraOnlineWebViewKeyboardManager/CollaboraOnlineWebViewKeyboardManager.m
@@ -238,14 +238,14 @@
     // to make some sense out of it by not trusting a hide request until we see that it hasn't been
     // folllowed by a display request within 100 ms.
     dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 100000000ll), dispatch_get_main_queue(), ^{
-            if (!lastCommandIsHide) {
+            if (!self->lastCommandIsHide) {
                 NSLog(@"COKbdMgr: Ignoring hide command that was quickly followed by a display command");
                 return;
             }
-            if (control != nil) {
-                [control removeFromSuperview];
+            if (self->control != nil) {
+                [self->control removeFromSuperview];
                 NSLog(@"COKbdMgr: Removed _COWVKMKeyInputControl from webView");
-                control = nil;
+                self->control = nil;
             }
         });
 }


More information about the Libreoffice-commits mailing list