[Libreoffice-commits] core.git: basctl/source

[Caolán McNamara (via logerrit)]

 basctl/source/inc/IDEComboBox.hxx |   22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)

New commits:
commit d56dbdf3cca6d7a19008a1267c64675daa7da525
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Apr 6 08:58:08 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Apr 6 15:11:50 2021 +0200

    drop stale TODOs
    
    Change-Id: Ia5d9666cf2b2a5f5227e727533a046ebcafbd72b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113629
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/basctl/source/inc/IDEComboBox.hxx b/basctl/source/inc/IDEComboBox.hxx
index 1420feecd2d5..3f1072511b8e 100644
--- a/basctl/source/inc/IDEComboBox.hxx
+++ b/basctl/source/inc/IDEComboBox.hxx
@@ -140,14 +140,6 @@ protected:
     /// Called for setting language when user selects a language in ComboBox
     virtual void Select() override;
 
-    /*!
-     * Handle keystrokes and mouse
-     *
-     * @param rNEvt represents mouse event
-     * @return a bool value: true if was handled, and false if there was nothing handled
-     */
-    //TODO    virtual bool PreNotify(NotifyEvent& rNEvt) override;
-
 private:
     static void ReleaseFocus();
 
@@ -165,6 +157,12 @@ private:
     /// Fill up the combobox
     virtual void FillBox() override;
 
+    /*!
+     * Handle keystrokes
+     *
+     * @param rKEvt represents key event
+     * @return a bool value: true if was handled, and false if there was nothing handled
+     */
     virtual bool HandleKeyInput(const KeyEvent& rKEvt) override;
 
     DECL_LINK(FocusInHdl, weld::Widget&, void);
@@ -244,15 +242,13 @@ protected:
     /// Called for setting language when user selects a language in ComboBox
     virtual void Select() override;
 
-    virtual bool HandleKeyInput(const KeyEvent& rKEvt) override;
-
     /*!
-     * Handle keystrokes and mouse
+     * Handle keystrokes
      *
-     * @param rNEvt represents mouse event
+     * @param rKEvt represents key event
      * @return a bool value: true if was handled, and false if there was nothing handled
      */
-    //TODO    virtual bool PreNotify(NotifyEvent& rNEvt) override;
+    virtual bool HandleKeyInput(const KeyEvent& rKEvt) override;
 
 private:
     /// Delete all languages from ComboBox