[Libreoffice-commits] core.git: include/svl svl/source

[Noel Grandin (via logerrit)]

 include/svl/itemprop.hxx      |   12 ++++++------
 svl/source/items/itemprop.cxx |    2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit cdf710200c2e9d8a335bf97ed73530f0d53c6376
Author:     Noel Grandin <noel at peralex.com>
AuthorDate: Mon Apr 12 09:04:46 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Apr 12 10:03:06 2021 +0200

    SfxItemPropertySimpleEntry constructor should take a reference
    
    not a pointer
    
    Change-Id: I09e356d9230e2cf386349aad028a41548cb050ea
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113965
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/include/svl/itemprop.hxx b/include/svl/itemprop.hxx
index 67cedb7a64b6..68d1a6681c90 100644
--- a/include/svl/itemprop.hxx
+++ b/include/svl/itemprop.hxx
@@ -94,12 +94,12 @@ struct SfxItemPropertySimpleEntry
             assert(_nFlags <= 0x1ff );
         }
 
-    SfxItemPropertySimpleEntry( const SfxItemPropertyMapEntry* pMapEntry )
-        : aType( pMapEntry->aType )
-        , nWID( pMapEntry->nWID )
-        , nFlags( pMapEntry->nFlags )
-        , nMemberId( pMapEntry->nMemberId )
-        , nMoreFlags( pMapEntry->nMoreFlags )
+    SfxItemPropertySimpleEntry( const SfxItemPropertyMapEntry& rMapEntry )
+        : aType( rMapEntry.aType )
+        , nWID( rMapEntry.nWID )
+        , nFlags( rMapEntry.nFlags )
+        , nMemberId( rMapEntry.nMemberId )
+        , nMoreFlags( rMapEntry.nMoreFlags )
         {
         }
 
diff --git a/svl/source/items/itemprop.cxx b/svl/source/items/itemprop.cxx
index 7f9c6cba72f3..d55677f77b70 100644
--- a/svl/source/items/itemprop.cxx
+++ b/svl/source/items/itemprop.cxx
@@ -58,7 +58,7 @@ SfxItemPropertyMap::SfxItemPropertyMap( const SfxItemPropertyMapEntry* pEntries
 {
     while( !pEntries->aName.empty() )
     {
-        (*m_pImpl) [ pEntries->aName ] = pEntries;
+        (*m_pImpl) [ pEntries->aName ] = *pEntries;
         ++pEntries;
     }
 }