[Libreoffice-commits] core.git: sc/source

Tor Lillqvist (via logerrit) logerrit at kemper.freedesktop.org
Wed Apr 14 07:16:00 UTC 2021


 sc/source/ui/app/inputwin.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 4f92acefe024a323c0a31ee991eff45eaf24029f
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Tue Apr 13 17:14:57 2021 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Wed Apr 14 09:15:26 2021 +0200

    Early return from ScInputWindow::setPosSizePixel() if no-op
    
    This seems to fix https://github.com/CollaboraOnline/online/issues/1988
    
    Change-Id: I5fd826647ce85b7ad2d93085fb0c2fa9db69e745
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114056
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114070
    Tested-by: Jenkins
    Reviewed-by: Tor Lillqvist <tml at collabora.com>

diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index 2da8fd62746f..67c12839a4ac 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -478,6 +478,10 @@ void ScInputWindow::SetSizePixel( const Size& rNewSize )
 
 void ScInputWindow::setPosSizePixel(tools::Long nX, tools::Long nY, tools::Long nWidth, tools::Long nHeight, PosSizeFlags nFlags)
 {
+    if ((!(nFlags & PosSizeFlags::Size) ||  GetSizePixel() == Size(nWidth, nHeight)) &&
+        (!(nFlags & PosSizeFlags::Pos) || GetPosPixel() == Point(nX, nY)))
+        return;
+
     ToolBox::setPosSizePixel(nX, nY, nWidth, nHeight, nFlags);
     if (const vcl::ILibreOfficeKitNotifier* pNotifier = GetLOKNotifier())
     {


More information about the Libreoffice-commits mailing list