[Libreoffice-commits] core.git: svx/source

[Noel Grandin (via logerrit)]

 svx/source/dialog/dlgctl3d.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 7852fdc1ae87434e06bbbfd05a349c4624fbfd50
Author:     Noel Grandin <noelgrandin at gmail.com>
AuthorDate: Sat Apr 17 14:08:30 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sat Apr 17 16:49:13 2021 +0200

    tdf#141701 Crash when closing 3D View dialog of 3D chart
    
    regression from
        commit 1d2773807f6d2deb1181ef4b14fbdd49ca1d5c14
        ref-count SdrPage
    we need to clear the SdrPage which releases some objects
    or some unhelpful DBG_UTIL mode code in ~SdrObject will
    kick in and try and release objects, but it ends
    up deleting child objects before parent objects,
    which cau
    
    Change-Id: Iaad89a05a30c119807beacc54aaa66b6fde634e3
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114223
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/svx/source/dialog/dlgctl3d.cxx b/svx/source/dialog/dlgctl3d.cxx
index ba8ac822fa62..0c7c62229bc9 100644
--- a/svx/source/dialog/dlgctl3d.cxx
+++ b/svx/source/dialog/dlgctl3d.cxx
@@ -63,6 +63,7 @@ void Svx3DPreviewControl::SetDrawingArea(weld::DrawingArea* pDrawingArea)
 
 Svx3DPreviewControl::~Svx3DPreviewControl()
 {
+    mxFmPage.clear();
     mp3DView.reset();
     mpModel.reset();
 }