[Libreoffice-commits] core.git: include/comphelper

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Sat Aug 7 08:28:06 UTC 2021


 include/comphelper/interfacecontainer3.hxx |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

New commits:
commit e20d997eb3eb5c81af907718989aba4a6f9fc950
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Fri Aug 6 15:48:22 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sat Aug 7 10:27:34 2021 +0200

    address some review comments
    
    from
       https://gerrit.libreoffice.org/c/core/+/77824
    
    Change-Id: I0e8d6958512a6063a3232136b6a61a865a0e6abf
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120120
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/include/comphelper/interfacecontainer3.hxx b/include/comphelper/interfacecontainer3.hxx
index 56cbeca61433..82fa1f5e6b3d 100644
--- a/include/comphelper/interfacecontainer3.hxx
+++ b/include/comphelper/interfacecontainer3.hxx
@@ -40,12 +40,12 @@ namespace comphelper
 {
 template <class ListenerT> class OInterfaceContainerHelper3;
 /**
-  This is the iterator of an InterfaceContainerHelper. Typically
+  This is the iterator of an OInterfaceContainerHelper3. Typically
   one constructs an instance on the stack for one firing session.
   It is not allowed to assign or copy an instance of this class.
 
   @tparam ListenerT UNO event listener type
-  @see OInterfaceContainerHelper
+  @see OInterfaceContainerHelper3
  */
 template <class ListenerT> class OInterfaceIteratorHelper3
 {
@@ -106,7 +106,12 @@ template <class ListenerT> void OInterfaceIteratorHelper3<ListenerT>::remove()
 
 /**
   A container of interfaces. To access the elements use an iterator.
-  This implementation is thread safe.
+  This implementation is thread-safe.
+
+  This is a copy of the code at include/comphelper/interfacecontainer2.hxx,
+  except that it is templatized on the type of the listener, which allows
+  some parts of the code to avoid doing an UNO_QUERY that can be expensive
+  in bulk.
 
   @tparam ListenerT UNO event listener type
   @see OInterfaceIteratorHelper
@@ -147,7 +152,7 @@ public:
         listener interface).
 
         @param rxIFace
-               interface to be added; it is allowed to
+               interface to be added; it is allowed to insert
                the same interface more than once
         @return
                 the new count of elements in the container


More information about the Libreoffice-commits mailing list