[Libreoffice-commits] core.git: bin/ui-rules-enforcer.py

[Caolán McNamara (via logerrit)]

 bin/ui-rules-enforcer.py |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

New commits:
commit 5ba46ce92810f0cf868e50fa4440500c91acbea5
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Mon Aug 9 12:04:39 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Mon Aug 9 15:12:01 2021 +0200

    enforce no image-position in GtkCheckButton/GtkRadioButton
    
    Change-Id: I686d0f3f66209a0e173065a2c28e7cf1960a28e8
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120203
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/bin/ui-rules-enforcer.py b/bin/ui-rules-enforcer.py
index 359f9c1231fb..ef73541958c8 100755
--- a/bin/ui-rules-enforcer.py
+++ b/bin/ui-rules-enforcer.py
@@ -208,6 +208,22 @@ def remove_check_button_relief(current):
     if relief != None:
       current.remove(relief)
 
+def remove_check_button_image_position(current):
+  image_position = None
+  ischeckorradiobutton = current.get('class') == "GtkCheckButton" or current.get('class') == "GtkRadioButton"
+  for child in current:
+    remove_check_button_image_position(child)
+    if not ischeckorradiobutton:
+        continue
+    if child.tag == "property":
+      attributes = child.attrib
+      if attributes.get("name") == "image_position" or attributes.get("name") == "image-position":
+        image_position = child
+
+  if ischeckorradiobutton:
+    if image_position != None:
+      current.remove(image_position)
+
 def remove_spin_button_input_purpose(current):
   input_purpose = None
   isspinbutton = current.get('class') == "GtkSpinButton"
@@ -393,6 +409,7 @@ replace_button_use_stock(root)
 replace_image_stock(root)
 remove_check_button_align(root)
 remove_check_button_relief(root)
+remove_check_button_image_position(root)
 remove_spin_button_input_purpose(root)
 remove_spin_button_max_length(root)
 remove_track_visited_links(root)